Git Product home page Git Product logo

Comments (3)

ctallec avatar ctallec commented on July 19, 2024

You are right, I'm fixing this asap. Thanks a lot ! If I'm not mistaken, this should not affect performance (the MDRNNCell is only used when training the controller, and in this case, we only rely on the hidden state of the RNN, not its outputs).

from world-models.

ranahanocka avatar ranahanocka commented on July 19, 2024

Cool, thanks for confirming!

Right. So in the original paper / implementation there was a variant where the MDRNN was used to predict the next state, in the "virtual" or "dream world" to train the controller. (So in that scenario it matters.)

BTW -- do you have any plans to implement the virtual environment in this repo? That would be really useful!

from world-models.

ctallec avatar ctallec commented on July 19, 2024

Yep indeed, this would impact training in the simulated environment, which is currently not implemented.
Both Léonard and I are quite busy at the moment, so we are not planning on implementing training in the dreamt environment in the near future. There is an untested facility to simulate rollouts using the trained VAE and MDN-RNN in envs/simulated_carracing.py. If you are willing to adapt this to allow for training in the dream, I would gladly review the PR !

from world-models.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.