Git Product home page Git Product logo

Comments (8)

jonathantneal avatar jonathantneal commented on May 28, 2024

Could you setup a test page? We need to see if this flickering still occurs in the last two versions of major browsers, and if so, exactly which browsers+versions this occurs in so that it can be precisely documented.

from sanitize.css.

davidhund avatar davidhund commented on May 28, 2024

Sure, I just whipped up a Codepen in 2 seconds. You see the "Open" and "Close" hyperlinks moving left/right...

http://codepen.io/davidhund/full/EaGWWG

from sanitize.css.

jonathantneal avatar jonathantneal commented on May 28, 2024

Awesome work (even if it was quick)! While I do see the scrollbar appear, I do not see any shifting in Chrome 40, Firefox 36, or Safari 8.0.5 for Mac. Which OSs/Browsers/Versions were you able to test?

from sanitize.css.

davidhund avatar davidhund commented on May 28, 2024

I see a (very slight) jump on Safari 6.1.6, Chrome 41.0.2272.89 and Firefox 31.0, all on the mac.

Make sure the content is centered (screen is > 30em) and place your mouse 'hand' cursor in the bottom middle of the "O" of the "Open" hyperlink. Clicking without moving your mouse pointer will show a shift and the pointer will be below the "l" of "Close". Clicking again.. etc... :-)

I could only quickly test on an older iMac but I'm pretty sure it happens almost everywhere...

from sanitize.css.

crswll avatar crswll commented on May 28, 2024

This would depend on the scroll bar settings in the OS. I agree that it's a good idea to add. I always thought of it as "layout shifting".

from sanitize.css.

jonathantneal avatar jonathantneal commented on May 28, 2024

Yes, I used to be a huge advocate of this, and I guess my experience on a Mac (and my secret hope) was that it was resolved. This shouldn’t be blocked by any other requests, even #2, which suggests overflow: hidden on all the things.

I would like to run a few more tests, particularly to see how Windows IE10+ machines handle this change, and how background images or colored, full-width elements are affected.

from sanitize.css.

jonathantneal avatar jonathantneal commented on May 28, 2024

I now believe :root { overflow-y: scroll; } is safe to add in. For operating systems and browsers that use the overlay scrollbar style, this pleasurable effect is not lost by defining overflow-y.

Also, a major aww yiss:

:root {
    -ms-overflow-style: -ms-autohiding-scrollbar; // gives IE the overlay style
}

That was tested in IE10 for Windows 7.

Notes:

  • MacOS Lion introduced the overlay style for scrollbars.
  • The overlay style does not impact horizontal space, which is nice.
  • MSDN mentions an -ms-overflow-style property that may be worth setting to -ms-autohiding-scrollbar by default, if it is supported in any IE.
  • Firefox added support for the overlay style: after hating on it. It’s a fun read.
  • There is no standard forthcoming for this overlay style. If there was, it fizzled.

See:

e2670d0

from sanitize.css.

davidhund avatar davidhund commented on May 28, 2024

Nice!

After-the-fact-FYI: Win7 Chrome 41.0.2272.89, Fx 36 and IE11 all have the layout shift.
Cool find re: -ms-autohiding-scrollbar! Works in Win7/IE11. overflow-y: scroll has no negative side-effects. Thanks!

from sanitize.css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.