Comments (6)
First, a warning; this site may have hijacked links to shareasale. Links to Genesis Framework seem to be compromised.
Second, thanks for sharing! Words like “accessibility”, “standards” and “framework” get me amped!
In this particularly case, the Leiden theme from Genesis Accessible is too specific for WordPress. What I mean is, it targets WordPress classnames rather than elements, attributes, and agnostic markup patterns.
The generic things it does target trouble me. For instance, the link to explain body > div { font-size: 1.6rem; }
is not working, but that seems particularly dangerous when it’s labeled as a Chrome fix. I don’t think Chrome has an issue with a div
being the child of body
. Similarly, outside WordPress a img { margin-bottom: -4px; margin-bottom: -0.4rem; }
might trip up developers.
I hope this explains my decision and doesn’t come across as a dismissal of your point. I’m a big fan of accessibility frameworks, so I never, ever want to discourage you or anyone from bringing one to my attention. Please, let me know if there were any particular patterns you found in Genesis Accessible, the plugin, the Leiden theme, or anywhere for that matter that I could pay closer attention to.
from sanitize.css.
cc @Rrwd
from sanitize.css.
@corvannoorloos @jonathantneal
The functionality the plugin Genesis Accessible and the theme Leiden are now integrated into Genesis core and the Genesis Sample Theme (https://github.com/copyblogger/genesis-sample).
The css is very specific to WordPress and to Genesis.
Is there anything specific you want me to look at here?
from sanitize.css.
@Rrwd not for me personally. Although I am a big fan of both Leiden and sanitize.css.
First, a warning; this site may have hijacked links to shareasale. Links to Genesis Framework seem to be compromised.
Perhaps I misunderstood, but mainly this and the reasoning after is why I linked both projects. I hope no one minded.
from sanitize.css.
First, thanks everyone for chiming in.
Re: hijacked links. I see one for example for “basic Genesis Framework” at http://genesis-accessible.org/installation/
Re: Sanitize / Genesis - anything for us to look at. I think @murrayac wanted me to look for elements to borrow from Genesis / Leiden. While I didn’t find anything, I will say that Sanitize.css could be a great use case for Genesis, paying close attention to https://github.com/10up/sanitize.css/blob/master/sanitize.scss#L270-L298
Even if you did not want to adopt Sanitize.css, this project is dedicated to the public domain, meaning I encourage you to freely take or expand upon anything you like without troubling yourself with licensing. Whatever benefits the users.
from sanitize.css.
Well, actually, the links are not hijacked, they're affiliate links, I earn some money with that.
I looked at the scss, specifically targeting ARIA seems like a good idea, yes.
from sanitize.css.
Related Issues (20)
- Height: 100% on html/body? HOT 1
- sanitize.css adds an extra dotted outline to focused buttons in Firefox HOT 1
- Pedantic colon placement HOT 1
- Why do we need `text-indent: 0` for the `table`s? HOT 5
- list-style-type:none for <ol> ? HOT 2
- Should set `cursor: pointer` on the `[aria-controls]` elements? HOT 3
- Accessibility fix: Allow iOS browsers to auto-scale fonts based on user preference HOT 7
- Other npm packages have references pages.css HOT 5
- zero-width space is consuming space in Safari
- Video captions to match body font family HOT 2
- iOS 15 brings up some new default styles HOT 1
- Pseudo-class :where()? HOT 4
- Text cursor not showing on paragraphs
- `nav li::before` breaks flexbox lists
- Touch-action is not in the stylesheet
- Add svg to assets.css
- Is this project alive/maintained? HOT 1
- Update README.md
- Consider removing opinionated tab-size
- Background transparency issue with iframe elements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sanitize.css.