Git Product home page Git Product logo

Comments (5)

carlosame avatar carlosame commented on September 24, 2024

Depends on #5.

from echosvg.

carlosame avatar carlosame commented on September 24, 2024

Do you have an actual use case for having the application title (library title in this case) in a resource file? If so, perhaps I could figure out which approach to follow.

EchoSVG currently contains a couple of applications, and one of them (named "svgbrowser") does have its name in a properties file: test-resources/io/sf/carte/echosvg/apps/svgbrowser/Main.properties. But that's probably not what you want.

In order to proceed, I need to understand the use case.

from echosvg.

 avatar commented on September 24, 2024

In order to proceed, I need to understand the use case.

I think it was mostly because Batik had me a little gun-shy. For example, I had no idea that it was sending its name out over HTTP requests. If the name was a constant defined in a single location, and used consistently from the single point, I could find all occurrences in the code base and be fairly certain there were no "gotchas", like with Batik. It's not so much a use case as peace of mind.

from echosvg.

carlosame avatar carlosame commented on September 24, 2024

I am not aware of any other place where EchoSVG is putting its name, although some tests do that in their generated output (where they use the SVGGeneratorContext.setComment(String) method which can be used to customize generated SVG).

But AFAIK you do not use generated SVG so that does not affect you (and the default is null which means that no comment is put).

from echosvg.

 avatar commented on September 24, 2024

Closing, we don't need to fix this.

from echosvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.