Comments (2)
rydmike
commented on August 17, 2024
Just a suggestion, but if you turn on the lint public_member_api_docs that you disabled, and turn it off in the examples, we don't need it there. Then you will be able to easily find all the public APIs that pub.dev is not happy about that are missing.
While going through the code, I did so, and added the missing API doc comments. Submitting a PR, use them if you like. Of course feel free to improve the doc comments. In some cases I was not entirely up to speed on what a good comment would be.
Also in some cases I edited existing doc comments to make them follow the Dart doc comments recommended style, so they are sentences that start with capital letter and end with a period. Does not matter so much in the code comments, but looks much better when it becomes doc pages.
from go_router.
csells
commented on August 17, 2024
Thanks, @rydmike! Fixed in v1.1.2.
from go_router.
Related Issues (20)
- Handle `errorBuilder` with Error Type HOT 5
- Please what tools did you use to build docs please share! HOT 1
- modal bottom sheet route
- Working With SPA in GoRouter HOT 1
- [Feature] allow push, pop, go operations in redirect callback HOT 2
- Fix nested navigation between multiple screen HOT 3
- Add the ability to hide/unhide CupertinoTabBar when GoRouter is used HOT 1
- Support for flutter_riverpod HOT 4
- Any thoughts on implementing "MiddleWare" to support deferred libraries? HOT 1
- Why is there an initialLocation but not a initialNamedLocation? HOT 1
- go Directly to books/new (tab child)
- Persistent context between routes HOT 1
- Unique PageKey doesn't work HOT 1
- Broken navigation behaviour on shared scaffold example. HOT 1
- How to deal with different navigation architectures on phones and tablets/web?
- Extra value is null when Widget inspector is open
- UrlPathStrategy.path is causing hot-reload in web
- redirect without page stack
- how to redirect without pushing
- Navigation rail in books example is not persistent
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go_router.