Git Product home page Git Product logo

Comments (9)

mverzilli avatar mverzilli commented on June 12, 2024

I'm not sure if the slow compile times are due to that, but we already know LLVM 3.5 generates incorrect code and are in the process of dropping support for it.

The Crystal version we use is here:

https://github.com/crystal-lang/heroku-buildpack-crystal/blob/master/bin/compile#L50

That is generated from https://github.com/crystal-lang/omnibus-crystal. There's already a WIP PR to move to LLVM 3.8 here: crystal-lang/omnibus-crystal#17

So this issue should be fixed once we merge that PR. If you're in a hurry, I guess you could try to build Crystal from source, publish it, fork this repo and change that line.

Hope this helps!

from heroku-buildpack-crystal.

crisward avatar crisward commented on June 12, 2024

Thanks, it does help. I'm already using a fork of the buildpack with a variation of libgc, so I may create / link my own binary and see if it effects compile time.

Thanks again for the prompt response...

from heroku-buildpack-crystal.

mverzilli avatar mverzilli commented on June 12, 2024

Cool! If it's not too much to ask, would you let us know how it goes? Would be useful to close the loop.

from heroku-buildpack-crystal.

crisward avatar crisward commented on June 12, 2024

Quick update, I gave this a go but the crystal I built on ubuntu 14.04 against llvm 3.8 through errors when I tried to build my app. Think I missed something along the way. Hopefully I'll get another chance to try this week. I should have noted down the errors, but it was one of those '2:00am, give up and go to bed' moments. I'll be a bit more systematic in my process next time.

from heroku-buildpack-crystal.

crisward avatar crisward commented on June 12, 2024

Its now impossible to compile in this buildpack with the lastest crystal as the 0.23 version required LLVM3.8>.

Looks like I'm stuck on 0.22 until this is resolved. See other discussion here - crystal-lang/crystal#4647

from heroku-buildpack-crystal.

mverzilli avatar mverzilli commented on June 12, 2024

@crisward, thanks for keeping us up to date. Don't worry about "getting stuck", we will not release any new Crystal versions until there's a 0.23.x that works on Ubuntu 14.04.

from heroku-buildpack-crystal.

crisward avatar crisward commented on June 12, 2024

Thanks, that's very reassuring.

from heroku-buildpack-crystal.

mverzilli avatar mverzilli commented on June 12, 2024

@crisward I think this is no longer an issue, is it ok if we close it?

from heroku-buildpack-crystal.

crisward avatar crisward commented on June 12, 2024

0.23.1 is compiled against 3.8, which sort of fixes this, however this has nothing really to do with the buildpack and more to do with the omnibus binaries. So I'll close. Thanks.

from heroku-buildpack-crystal.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.