Git Product home page Git Product logo

Comments (10)

xeroc avatar xeroc commented on July 17, 2024

from graphene.

 avatar commented on July 17, 2024

SmartCoin holders see the following using the gui

Failed to broadcast the transaction:
Cannot force settle with no price feed.

and in the cli

0 exception: unspecified
37006 insufficient_feeds: insufficient feeds
Cannot force settle with no price feed.

I cannot publish a price feed due to the blackswan.

Is global_settle_asset useful in this situation?

from graphene.

pmconrad avatar pmconrad commented on July 17, 2024

That looks like a bug.
No, global_settle_asset won't help you there.

from graphene.

 avatar commented on July 17, 2024

Thanks for your replies xeroc and pmconrad.

I have been using the test-net to settle smartcoins after a blackswan.

ALTCAP.X, SETTLE and SETTLE.WEEK have now all been force settled due to lack of collateral on the test net. In doing this, I have found FEED LIFETIME IN MINUTES to be very important in allowing holders to settle their smartcoins.

SETTLE.WEEK was created with a FEED LIFETIME of 10080 minutes (one week) to test settlement of the asset for up to one week after a blackswan. I will post later if this works as planned.

A 24 hour feed lifetime is insufficient time to allow holders to settle and recover collateral. I apologize to the ALTCAP.X holders for not testing this setting thoroughly and hope ALTCAP.X can be reset in the future to allow holders to recover their funds.

In light of this, I have changed FEED LIFETIME to 10080 minutes for ALTCAP on the bitshares network and recommend the committee increases FEED LIFETIME on all bitASSET smartcoins.

from graphene.

grctest avatar grctest commented on July 17, 2024

Relevant bitsharestalk thread: https://bitsharestalk.org/index.php/topic,23334.0.html

The GRIDCOIN MPA (in blackswan state) doesn't have the 'Force Settlement' option (gave up said permission).

from graphene.

pmconrad avatar pmconrad commented on July 17, 2024

The GRIDCOIN MPA (in blackswan state) doesn't have the 'Force Settlement' option (gave up said permission).

That doesn't matter. After a black swan, forced settlement is allowed in any case. https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L436

FEED_LIFETIME shouldn't matter, because after a black swan settlement doesn't happen at the feed price but at the (fixed) settlement_price. That is a bug that needs fixing. Should be allowed here but isn't: https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L439

from graphene.

 avatar commented on July 17, 2024

Yes "FEED_LIFETIME shouldn't matter" but it does at the minute.
Now on bitshares and the test-net you have only the "FEED_LIFETIME" to settle your smartcoins after a blackswan.

The test I mentioned above:
SETTLE - I cannot settle because the 24 hour FEED_LIFETIME has passed
SETTLE.WEEK can still be settled because FEED_LIFETIME is 10080 minutes (1 week)

from graphene.

abitmore avatar abitmore commented on July 17, 2024

FEED_LIFETIME shouldn't matter, because after a black swan settlement doesn't happen at the feed price but at the (fixed) settlement_price. That is a bug that needs fixing. Should be allowed here but isn't: https://github.com/cryptonomex/graphene/blob/master/libraries/chain/asset_evaluator.cpp#L439

The code

   else if( bitasset.current_feed.settlement_price.is_null() )
      FC_THROW_EXCEPTION(insufficient_feeds, "Cannot force settle with no price feed.");

perhaps should be

   else if( bitasset.current_feed.settlement_price.is_null() || bitasset.has_settlement())
      FC_THROW_EXCEPTION(insufficient_feeds, "Cannot force settle with no price feed.");

so an asset not in black swain state shouldn't be forced settled if no enough price feed provided.

Thoughts?

from graphene.

pmconrad avatar pmconrad commented on July 17, 2024

Close... I think this would be the correct condition:

else if( bitasset.current_feed.settlement_price.is_null() && !bitasset.has_settlement())

i. e. throw an error if neither feed nor settlement are available. Settlement is possible with either feed or settlement.

from graphene.

vikramrajkumar avatar vikramrajkumar commented on July 17, 2024

This issue was moved to bitshares/bitshares-core#216

from graphene.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.