Git Product home page Git Product logo

Comments (8)

sidework avatar sidework commented on May 29, 2024

For the record, options are always great, but I would never turn this option on. There are contracts out there that are scams that are written to only approve for the token owner. UNI will let you buy it, and then when you go to sell, it fails because you cant approve it. I would rather be safe than sorry. Maybe it would make more sense to approve it right away when adding the pair for trading, regardless of buying/selling at the moment? I would turn that on... :)

from limitswap.

CryptoGnome avatar CryptoGnome commented on May 29, 2024

yea in some ways I agree, you can go to uniswap and approve manually if you are that concerned
We will keep this open for debate and see what others say

from limitswap.

eazyEE-create avatar eazyEE-create commented on May 29, 2024

For the record, options are always great, but I would never turn this option on. There are contracts out there that are scams that are written to only approve for the token owner. UNI will let you buy it, and then when you go to sell, it fails because you cant approve it. I would rather be safe than sorry. Maybe it would make more sense to approve it right away when adding the pair for trading, regardless of buying/selling at the moment? I would turn that on... :)

I agree 100%, but leave it up to the user to decide this, maybe a banner to warn the user about scam coins when toggle is turned on?

Let the user do their due diligence when investing.

from limitswap.

eazyEE-create avatar eazyEE-create commented on May 29, 2024

yea in some ways I agree, you can go to uniswap and approve manually if you are that concerned
We will keep this open for debate and see what others say

Were you planning on implementing this on the next update?

from limitswap.

jondoeog avatar jondoeog commented on May 29, 2024

I would really love to see that feature on. I use bot mostly to trade coins that I know or when I want to snipe something fast, having approve before buy kind of ruin the play.

Definitely choice for user would be great!

from limitswap.

pasil11 avatar pasil11 commented on May 29, 2024

I think this option would be appreciated (as you wrote we can approve manually in UNI or etherscan)

from limitswap.

eazyEE-create avatar eazyEE-create commented on May 29, 2024

I think this option would be appreciated (as you wrote we can approve manually in UNI or etherscan)

Yeah you can manually if the token is live and trading, but if there's no liquidity you can't because you need the pair address

from limitswap.

jondoeog avatar jondoeog commented on May 29, 2024

Any ETA when it might get implemented?

from limitswap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.