Comments (8)
For the record, options are always great, but I would never turn this option on. There are contracts out there that are scams that are written to only approve for the token owner. UNI will let you buy it, and then when you go to sell, it fails because you cant approve it. I would rather be safe than sorry. Maybe it would make more sense to approve it right away when adding the pair for trading, regardless of buying/selling at the moment? I would turn that on... :)
from limitswap.
yea in some ways I agree, you can go to uniswap and approve manually if you are that concerned
We will keep this open for debate and see what others say
from limitswap.
For the record, options are always great, but I would never turn this option on. There are contracts out there that are scams that are written to only approve for the token owner. UNI will let you buy it, and then when you go to sell, it fails because you cant approve it. I would rather be safe than sorry. Maybe it would make more sense to approve it right away when adding the pair for trading, regardless of buying/selling at the moment? I would turn that on... :)
I agree 100%, but leave it up to the user to decide this, maybe a banner to warn the user about scam coins when toggle is turned on?
Let the user do their due diligence when investing.
from limitswap.
yea in some ways I agree, you can go to uniswap and approve manually if you are that concerned
We will keep this open for debate and see what others say
Were you planning on implementing this on the next update?
from limitswap.
I would really love to see that feature on. I use bot mostly to trade coins that I know or when I want to snipe something fast, having approve before buy kind of ruin the play.
Definitely choice for user would be great!
from limitswap.
I think this option would be appreciated (as you wrote we can approve manually in UNI or etherscan)
from limitswap.
I think this option would be appreciated (as you wrote we can approve manually in UNI or etherscan)
Yeah you can manually if the token is live and trading, but if there's no liquidity you can't because you need the pair address
from limitswap.
Any ETA when it might get implemented?
from limitswap.
Related Issues (20)
- ERROR: 2021-10-28 00:13:42,864 Expecting ',' delimiter: line 12 column 5 (char 297) HOT 1
- SELLAMOUNTINTOKENS incorrect value sold HOT 2
- To add vwap and aud or usd currency to the price on the right HOT 1
- Please add TraderJoe exchange (Avalanche) HOT 1
- I downloaded from github the latest version 3.35 but the bot gives an error and asks to update the version
- Unable to buy in TraderJoe HOT 1
- Buy Exact Amount of Token
- Bot is not buying on uniswap - tx not visible on blockchain HOT 3
- [LimitSwap] Crash as soon as liquidity is added HOT 2
- NOT ENOUGH LIQUIDITY HOT 2
- SELLAMOUNTINTOKENS is not working HOT 2
- Gwei with pancake swap
- Add BUYFROMPRICE option HOT 2
- LimitSwap not buying - too many zeros HOT 2
- Falling over on eth setup HOT 1
- Please add "BUY EXACTTOKENS" function HOT 1
- opentrade function solution HOT 1
- improper settings/tokens loading errors
- Support Non-Verified Contracts HOT 1
- Cronos chain
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limitswap.