Git Product home page Git Product logo

Comments (2)

andrewazores avatar andrewazores commented on July 17, 2024

There are a few options here:

  1. Add some logic to the existing ci.yml to check if the github.ref/github.ref_name matches cryostat-vX.Y, and if so, tag the image as X.Y.Z. Would Z always be 0, or how else would it be supplied?
  2. Change the release process - rather than creating release branches named like cryostat-v2.4, create a release branch named 2.4.0. The existing ci.yml action will automatically tag the image correctly in this case.
  3. Change the release process - create release branches named like cryostat-2.4.0. Combined approach of 1 and 2.
  4. Remove the github.ref_name from the ci.yml. In release branches, add a manual process step where the versioned tag is added or updated to the image tags list in the ci.yml. ie upstream main will always just be tagged main and latest, but a release cut from cryostat-v2.4 release branch will have its ci.yml updated to be tagged 2.4.0.
  5. Add some logic to the existing ci.yml using git describe or similar and use git tags to feed the version tag info to the CI build. This can be a replacement for or in addition to the github.ref_name (release branch name).

from cryostat-grafana-dashboard.

ebaron avatar ebaron commented on July 17, 2024

It's probably okay to keep the image tags from the release branches as cryostat-v2.4. I was more concerned about when we actually cut the release. We could do something like check if it's a tag that triggered the workflow, and if so, strip the v off the beginning when tagging the image.

from cryostat-grafana-dashboard.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.