Comments (2)
There are a few options here:
- Add some logic to the existing
ci.yml
to check if thegithub.ref
/github.ref_name
matchescryostat-vX.Y
, and if so, tag the image asX.Y.Z
. WouldZ
always be0
, or how else would it be supplied? - Change the release process - rather than creating release branches named like
cryostat-v2.4
, create a release branch named2.4.0
. The existingci.yml
action will automatically tag the image correctly in this case. - Change the release process - create release branches named like
cryostat-2.4.0
. Combined approach of 1 and 2. - Remove the
github.ref_name
from theci.yml
. In release branches, add a manual process step where the versioned tag is added or updated to the image tags list in theci.yml
. ie upstreammain
will always just be taggedmain
andlatest
, but a release cut fromcryostat-v2.4
release branch will have itsci.yml
updated to be tagged2.4.0
. - Add some logic to the existing
ci.yml
usinggit describe
or similar and use git tags to feed the version tag info to the CI build. This can be a replacement for or in addition to thegithub.ref_name
(release branch name).
from cryostat-grafana-dashboard.
It's probably okay to keep the image tags from the release branches as cryostat-v2.4
. I was more concerned about when we actually cut the release. We could do something like check if it's a tag that triggered the workflow, and if so, strip the v
off the beginning when tagging the image.
from cryostat-grafana-dashboard.
Related Issues (15)
- Should the default dashboard be named "Dashboard"? HOT 1
- Use latest tag in build.sh
- Release version 2.0.0
- Bump Grafana to 7.5.15
- Kubernetes can't verify that image runs as non-root
- [Task] Redesign Grafana Dashboard HOT 12
- [Task] Automatically find time range for data in graphs
- [Task] Panels should have helper texts
- [Task] Set up Dependabot
- Build with GitHub CI HOT 1
- [Bug] `grafana-simple-json-datasource` plugin not loaded HOT 2
- [Epic] Move away from `grafana-simple-json-datasource` HOT 2
- Migrate panels from Angular plugins
- [Request] Can the Object Allocation sub-dashboard have dynamic categories? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryostat-grafana-dashboard.