Subnetwork should not update 'network' field about provider-gcp HOT 4 CLOSED

CC @muvaf

from provider-gcp.

I also noticed the privateIpGoogleAccess JSON struct tag is set to PrivateIPGoogleAccess - I fixed that in my branch in order to apply the example above.

from provider-gcp.

The following field(s) specified in the request cannot be modified: [network]

The same happened for region and I fixed it in the Update call but I don't know why I didn't see that one during the tests. I'll fix it asap.

These things get me thinking of having admission webhook for each resource that is generated to do these checks that CRD validation is not capable of. I think kubebuilder generates webhook but empty ones, maybe we can add our own comment tags on struct fields and extend that generation functionality of kubebuilder to generate validation checks in the admission webhook according to these tags.

I also noticed the privateIpGoogleAccess JSON struct tag is set to PrivateIPGoogleAccess

That was because of copy-paste from Google's struct. I corrected it in our structs while moving the commits to stack-gcp repo.

from provider-gcp.

@muvaf Did this get fixed somewhere along the way?

from provider-gcp.