Git Product home page Git Product logo

Comments (2)

cronoh avatar cronoh commented on August 23, 2024

I think going with 2 by default is the best way to go here. Essentially, only save the wallet unencrypted if the 'Do not lock on close' option is selected, otherwise encrypt it on save (If its not already locked, for example when adding a new account). I think the wallet loses a lot of its reusability for basic users if we don't save by default, but I agree that there is no good reason not to always encrypt that info unless the user specifically sets it to not to.

There are a few considerations I will need to think through to make sure all of the situations are covered, but I will try and get this implemented soon and update here when it's ready. Thanks for the feedback @termhn!

from nanovault.

cronoh avatar cronoh commented on August 23, 2024

Because the wallet already automatically locks (And therefore encrypts) on close, I am going to consider that a sufficient solution for now. Please reply if you think this needs to be changed!

from nanovault.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.