BUG: the message parser doesnt seem reflect the underlying data. about fb-messenger-bot-api HOT 6 CLOSED

Hi @MartinSahlen , I am looking at it now.

from fb-messenger-bot-api.

Hi, I had a look over it and the issue was that the return type of FacebookMessageParser.parsePayload() is FacebookMessagePayloadEntry whereas the correct type should be FacebookMessagePayloadMessagingEntry indeed. Pushed changes and 4.2.0 should have this fixed and not require anymore casting. Thanks for the heads up :)

from fb-messenger-bot-api.

This is what I had to do:

import {
  FacebookMessageParser as messageParser,
  FacebookMessagePayloadMessagingEntry,
} from 'fb-messenger-bot-api';
import { Request } from 'express';

export const parseMessagePayload = (req: Request) => {
  const messages = messageParser.parsePayload(req.body);
  // tslint:disable-next-line:no-any
  return (messages as any) as FacebookMessagePayloadMessagingEntry[];
};

from fb-messenger-bot-api.

@crisboarna Did you see this?

from fb-messenger-bot-api.

@crisboarna : IMO, the messages received from facebook messenger and they need to casted in proper types.
If you look in to https://developers.facebook.com/docs/messenger-platform/reference/webhook-events/messages
and https://developers.facebook.com/docs/messenger-platform/reference/webhook-events/message-deliveries

I think as part of parse payload the parsed payload type should be decided.

from fb-messenger-bot-api.

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from fb-messenger-bot-api.