Comments (3)
@kenmoini This should already be covered by the extraObjects
value (see the extras.yaml
template). Let me know if that doesn't work for your use case.
I'm not opposed to adding OpenShift-specific templates to the chart 🙂
from helm-charts.
Hey @bdalpe - the extraObjects
value should be useful for maybe custom things like Jobs for niche deployments where a user is doing some init/batch processing, and could certainly be used for the OpenShift route.
However, I think it'd probably be more valuable and easier for both of our user bases if you could simply toggle openshift.enable=true
instead of having them provide the full manifest for a Route - what do you think?
I've already made the needed changes here in my fork: https://github.com/kenmoini/cribl-helm-charts/tree/patch-184/helm-chart-sources/logstream-leader
Includes a default of assuming it is not an OpenShift deployment for backwards compat, ability to disable the Route object in case they're using a different Ingress on OpenShift, as well as the needed tests for all the various inputs. The use of the openshift.enable=true
value should also provide simplicity for some other patches we'll need to make running Cribl on OpenShift much easier for users.
If you think it's suitable to provide users a quick and easy toggle to deploy to OpenShift with use of Routes, lemme know and I can make a quick PR.
from helm-charts.
I like the openshift.enable value idea. This would allow for setting other important things like namespace annotations, etc.
from helm-charts.
Related Issues (20)
- Sign Releases
- Add emphemeral-storage limits
- Edge RBAC extraRules has incorrect yaml syntax
- Strategy implemented in wrong spec HOT 1
- podSecurityContext non-existent in logstream-leader chart
- securityContext not set on logstream-leader Pod
- resources config on logstream-leader chart too deep
- Custom .gitignore file
- Support `extraVolumes` for Cribl workergroups helm charts HOT 6
- Remove `:` in role & rolebinding names HOT 5
- Allow `get namespace` in Edge chart
- 404 link to Docs
- Make EKS Add-on ready HOT 2
- Separate logstream-leader service and service-internal annotations HOT 1
- Run as non-root, OpenShift support HOT 5
- Reduce ClusterRole{Bindings}s to namespaced Role{Bindings}s in logstream-workergroup HOT 3
- Hardcoded transport `tcp` comms to the leader node HOT 5
- Cribl leader TLS value should be a list not a dictionary HOT 1
- Static PVC name leader-config-claim - can't deploy multiple Leaders in the same namespace HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-charts.