Support for OpenShift Routes about helm-charts HOT 3 OPEN

@kenmoini This should already be covered by the extraObjects value (see the extras.yaml template). Let me know if that doesn't work for your use case.

I'm not opposed to adding OpenShift-specific templates to the chart 🙂

from helm-charts.

Hey @bdalpe - the extraObjects value should be useful for maybe custom things like Jobs for niche deployments where a user is doing some init/batch processing, and could certainly be used for the OpenShift route.

However, I think it'd probably be more valuable and easier for both of our user bases if you could simply toggle openshift.enable=true instead of having them provide the full manifest for a Route - what do you think?

I've already made the needed changes here in my fork: https://github.com/kenmoini/cribl-helm-charts/tree/patch-184/helm-chart-sources/logstream-leader

Includes a default of assuming it is not an OpenShift deployment for backwards compat, ability to disable the Route object in case they're using a different Ingress on OpenShift, as well as the needed tests for all the various inputs. The use of the openshift.enable=true value should also provide simplicity for some other patches we'll need to make running Cribl on OpenShift much easier for users.

If you think it's suitable to provide users a quick and easy toggle to deploy to OpenShift with use of Routes, lemme know and I can make a quick PR.

from helm-charts.

I like the openshift.enable value idea. This would allow for setting other important things like namespace annotations, etc.

from helm-charts.