Git Product home page Git Product logo

Comments (12)

sameo avatar sameo commented on June 9, 2024 1

@mrunalp Do you agree this is fixed with commit a4f5c3a ?

from cri-o.

cyphar avatar cyphar commented on June 9, 2024 1

why not having people checkout CNI repo since they basically have the same examples?

I was assuming "people" meant me packaging ocid. I'll add an example tomorrow (/me -> bed). 😉

from cri-o.

cyphar avatar cyphar commented on June 9, 2024

@sameo Can we please include the "sample CNI configuration" in the repo so that distributions can package it, and that the README is just "here's a sample file".

from cri-o.

runcom avatar runcom commented on June 9, 2024

@sameo Can we please include the "sample CNI configuration" in the repo so that distributions can package it, and that the README is just "here's a sample file".

@cyphar mmm, why not having people checkout CNI repo since they basically have the same examples? it won't change, but if the config changes we'll need to track CNI from this repo

from cri-o.

runcom avatar runcom commented on June 9, 2024

(no strong opinion on this though, feel free to include a config sample if you feel strongly about it)

from cri-o.

cyphar avatar cyphar commented on June 9, 2024

Including the CNI source code in an RPM just to get an example configuration seems to me to be a little overkill. ;)

from cri-o.

runcom avatar runcom commented on June 9, 2024

Including the CNI source code in an RPM just to get an example configuration seems to me to be a little overkill. ;)

nah, I didn't mean that (if I got correctly what you said)

from cri-o.

runcom avatar runcom commented on June 9, 2024

@cyphar the misunderstanding lies in me saying checkout CNI repo - by checkout I meant have a look on the github repo on the web

from cri-o.

cyphar avatar cyphar commented on June 9, 2024

Ah, right. "go check out" not git checkout. 😸

from cri-o.

runcom avatar runcom commented on June 9, 2024

Ah, right. "go check out" not git checkout.

I should take another english class soon...myb

from cri-o.

mrunalp avatar mrunalp commented on June 9, 2024

@sameo Yeah, I think we are good. I am okay either ways on adding the config files. Will wait for @cyphar

from cri-o.

cyphar avatar cyphar commented on June 9, 2024

This is in #295.

from cri-o.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.