Comments (5)
Disabled the redundant rule for ConfigOptions.swift and all rules for the generated files: 91af76e
from createapi.
I guess to get started, what rules do we want? A first autocorrect
run doesn't produce much, only Array<...>
to [...]
and some whitespace removed.
from createapi.
That sounds like a good start. If we can start with the default rules that are enabled and correct everything then that is probably already good enough.
Maybe we can take some examples from other public style guides beyond that? Some that I know of:
- https://github.com/airbnb/swift/blob/master/Sources/AirbnbSwiftFormatTool/swiftlint.yml
- https://github.com/raywenderlich/swift-style-guide/blob/main/com.raywenderlich.swiftlint.yml
from createapi.
I started with the raywenderlich config, removed some options that didn't apply, and added a few to get to this config: https://github.com/LePips/CreateAPI/blob/swiftlint/.swiftlint.yaml
You can see what changes it made with a first autocorrect: LePips@80551e9
Overall, mainly fixes spacing, changes Array<type>
declarations to [type]
, and some type redundancies. Forgot to make it ignore the sourcery generated files in that initial commit.
from createapi.
Looks like a good start!
We’ll want to ignore the redundant default value in ConfigOptions.swift because that is used to generate documentation, and we’ll also want to ignore the DecodableWithDefault extension since that’s generated code
from createapi.
Related Issues (20)
- Request uses incorrect body instead of asQuery HOT 1
- Schema component named `Request` generates ambiguous code HOT 4
- `AnyJSON` type included unexpectedly
- Adjust behaviour of `includeDefaultValues` to favour "correctness" by default HOT 1
- integer backed enums are stored as integer properties as opposed to enums HOT 1
- generated package depends on an old version of Get HOT 3
- Tagged type for IDs? HOT 2
- FR: Entity replace substring, instead of naming template HOT 1
- Equatable conformance HOT 1
- Parameters to be passed in headers are ignored during API generation
- Acronyms change property names without changing corresponding CodingKeys
- Deduplicate identical structs/classes
- Add option to separate GET from POST and PATCH requests and only include Decodable respectively Encodable conformance
- Option for treating non-optional enum with only one case as a static value
- `type` definition in OpenAPI spec is overridden by `format` value
- Is there a way to generate `CodingKeys`?
- How to wildcard rules in include and exclude paths
- Use `Swift Syntax`
- Make 'Request' type name configurable HOT 1
- Will OpenAPI schema v3.1.0 be supported?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from createapi.