Git Product home page Git Product logo

Comments (5)

LePips avatar LePips commented on June 6, 2024 1

Disabled the redundant rule for ConfigOptions.swift and all rules for the generated files: 91af76e

from createapi.

LePips avatar LePips commented on June 6, 2024

I guess to get started, what rules do we want? A first autocorrect run doesn't produce much, only Array<...> to [...] and some whitespace removed.

from createapi.

liamnichols avatar liamnichols commented on June 6, 2024

That sounds like a good start. If we can start with the default rules that are enabled and correct everything then that is probably already good enough.

Maybe we can take some examples from other public style guides beyond that? Some that I know of:

from createapi.

LePips avatar LePips commented on June 6, 2024

I started with the raywenderlich config, removed some options that didn't apply, and added a few to get to this config: https://github.com/LePips/CreateAPI/blob/swiftlint/.swiftlint.yaml

You can see what changes it made with a first autocorrect: LePips@80551e9

Overall, mainly fixes spacing, changes Array<type> declarations to [type], and some type redundancies. Forgot to make it ignore the sourcery generated files in that initial commit.

from createapi.

liamnichols avatar liamnichols commented on June 6, 2024

Looks like a good start!

We’ll want to ignore the redundant default value in ConfigOptions.swift because that is used to generate documentation, and we’ll also want to ignore the DecodableWithDefault extension since that’s generated code

from createapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.