Git Product home page Git Product logo

Comments (3)

hasheddan avatar hasheddan commented on July 26, 2024

@eladb I love this feature! A few thoughts:

  • Adding an endpoint that returns a list of all CRDs for a project should be relatively straight-forward 👍
  • Allowing a user to download a CRD for a project could be pretty easy as we could just proxy the raw github content

One thing that would make this experience potentially less than ideal is that the filepath in the repo in currently used as the unique identifier for a CRD. The reason for this is that a CRD may be present in multiple locations in a repo (you can see this on https://doc.crds.dev/github.com/crossplane/crossplane for example) and we are not able to say for sure which is the "true" CRD representation. Therefore, if you wanted to download all crossplane/crossplane CRDs we would likely return some duplicates. If they are the same, this should be okay because if you are kubectl apply -f for example then you would just get something like unchanged.

One thing I have been thinking about is allowing projects to put some sort of doc.crds file in their repo that has config that we will honor if present. This would allow projects who opt-in to have a better experience for users, and for those who do not, they would just get a best-effort. Do you have any thoughts on these points?

from doc.

hasheddan avatar hasheddan commented on July 26, 2024

This has been addressed in #93

from doc.

eladb avatar eladb commented on July 26, 2024

🚀

from doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.