Git Product home page Git Product logo

Comments (5)

craigmiskell avatar craigmiskell commented on July 21, 2024

1.1.4 only got released yesterday, and it changed how the content script gets injected to capture cookies set by javascript. It's quite likely there's something not working with that new approach.

But: it works fine for me on anime-planet.com (cookies are blocked and the indicator shows correctly) and interestingly many of the cookies are set by headers, and nothing about that code changed in 1.1.4 (just cookies set by Javascript). Maybe there's some unexpected interaction with one of your other extensions.

Some logs might help; with as few browser tabs open as possible, could you open a fresh tab, click on the cookiemaster icon and then click Logs. In the Logging Level dropdown at the top, select 'DEBUG". Then in your fresh tab navigate to a problem site like anime-planet.com. Once it has loaded, copy/paste the logs from the log window and email them to me (there may be slightly sensitive information in them and a public issue is probably not the right place to attach them directly).

from cookiemaster.

ArcticGems avatar ArcticGems commented on July 21, 2024

@craigmiskell
Sent the debug log to your email you have on your mozilla addon page.

from cookiemaster.

craigmiskell avatar craigmiskell commented on July 21, 2024

Hmmm, that's practically silent, suggesting cookiemaster isn't getting a chance to do anything. I have nothing firm to go on, but feels like either a bug that causes an exception so early on nothing much can process (but weirdly, is fine on e.g. github.com), or else one of your other extensions is getting involved in some fashion that causes grief (or a combination of both :))

Could you please:

  1. Tell me what version of firefox you're using
  2. Tell me what other extensions you have (particularly privacy/security type ones)
  3. Try cookiemaster in a firefox profile with no other extensions. Goto "about:profiles", create a new profile, click 'Launch profile in new browser' then add cookiemaster to that profile. Then visit the problem sites and see if cookiemaster works as expected. If it does, it's some interaction with your other extensions
  4. Optional: Send me the logs again, but this time at TRACE level. This is a firehose of data (if cookiemaster is working), and definitely contains sensitive information like cookie values (if any) from headers, so you'd want to have firefox only open with the problem site (nothing else at all, in any tab, while collecting logs). If you'd rather not, I'm fine with that too, if you'd just like to turn it on and have a look for anything obviously wrong. I'd be very interested in the first few lines after 'beforeNavigate with frameId X; clearing tabInfo', if they look safe to send.

from cookiemaster.

ArcticGems avatar ArcticGems commented on July 21, 2024

@craigmiskell

  1. FF 75.0
  2. uBlock origin, NoScript, Ghostery, Smart HTTPS, ClearURLs
    3-4. Will do when I get home again later.

Went to 'Firefox options>Privacy & Security>Cookies and Site Data>Manage Data...' and removed site data for anime-planet.com and after a refresh the indicator came back.

When I do the same thing again as in #17 (comment), the permission indicator disappears again.

from cookiemaster.

craigmiskell avatar craigmiskell commented on July 21, 2024

I managed to replicate the problem, and it seems to be uBlock origin that triggers it. Once there is a cookie stored the set-cookie header is removed before cookiemaster gets a chance to see it. From a very brief search through the code for uBlock, I couldn't see exactly where, but with extra logging it was very clear that the header was simply missing. It's also (very slightly) possible that the website is behaving differently, but that seems rather unlikely.

So it's not a bug in cookiemaster; it's doing exactly what it is asked to do, given the data it is seeing (no cookie headers), and there's no code changes that could be made to make it behave differently.

On the plus side: you're not getting any cookies from this site :)

from cookiemaster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.