Comments (4)
Thanks for reporting this. I think I made a mistake in the revised logic that creates the executable cmd. Your workflow shows it trying to use the Linux cmd clang-tidy-12
when it should be resolving to just clang-tidy
(or path\to\bin\clang-tidy.exe
if specifying the binary exe's path as the version
option).
I'll have a fix submitted by tomorrow, but I need to test it (more/better). I honestly don't know how our last test didn't show this problem.
BTW, the Windows runner comes with v13, not v12. Unless your boost lib cache includes/overwrites the clang version that comes with the Windows venv. Sometimes I get lucky with cross-version differences of clang-tools, but usually there's breaking differences in what clang-tools expects in their config.
from cpp-linter-action.
I honestly don't know how our last test didn't show this problem.
@2bndy5 Do you find the reason why our last test (in this run https://github.com/cpp-linter/test-cpp-linter-action/actions/runs/2527084295) did not show FileNotFoundError
? We'd better prevent it from happening again
from cpp-linter-action.
After researching the point of error, I found that red-panda-productions/DAISI workflow is improperly passing the version number to the version
arg. When running on a Windows runner, the only ways to invoke a clang tool executable is to use
clang-tidy
/clang-format
(this invokes whatever the default provided version is for the runner)path\to\bin\clang-tidy.exe
/path\to\bin\clang-format.exe
(this is used to specify a specifically installed version)
As stated in the README, Windows runners now come with v13 of the clang tools. If you want to use a specifically installed version on Windows then you have to pass the path it was installed to. (see example in README). Our python code will then check if the path has a bin
folder and execute path\to\bin\clang-<tool>.exe
(only the path\to
part needs to be passed to the version
arg).
To summarize, the working state of the red-panda-productions/DAISI workflow passes 12
to the version arg, but our action will only execute clang-<tool>
. This ends up using v13 because (from what I can tell) v12 is not installed in the runner's environment, and calling clang-<tool>
(without the .exe
) invokes whatever executable is found in the OS's PATH
env variable.
from cpp-linter-action.
My faulty logic revision in #66 (now fixed by #68) allowed this improper usage of the version
arg to surface as an error. The bad logic ended up calling clang-tidy-12
on windows when that can only work on Linux (& possibly MacOS).
from cpp-linter-action.
Related Issues (20)
- Iinter keep giving 1 error & notice HOT 4
- Add support for clang-tools v16 HOT 6
- apt-get is missing -y and gets stuck due to interactive mode HOT 6
- Update README about new step-summary and revised thread comments HOT 3
- Update thread comment once format checks are successful. HOT 4
- Improve paths handling HOT 2
- .clang-tidy is not considered HOT 2
- How to specify "Build path" (`-p`) for .clang-tidy? HOT 2
- Option to only post thread comment when errors are detected HOT 14
- Warning: 2 File(s) not formatted (should be 1) HOT 3
- How to make cpp-linter-action work with Conan? HOT 5
- Seperate output for `clang-format` and `clang-tidy` HOT 5
- Python `error: externally-managed-environment` during installation HOT 32
- _pygit2.GitError: repository path '/__w/Waybar/Waybar/' is not owned by current user HOT 6
- [BUG][v2.7.4] _pygit2.GitError: trailing data at line 3734 HOT 12
- Preparing for v2.9.0 PR review feature release HOT 8
- State what python version is used in README HOT 8
- create an examples folder to demonstrate various usage HOT 2
- generate the "Inputs and Outputs" page using action.yml
- cpp-linter workflows runs for every change HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpp-linter-action.