Add support for other CI tools (via python package) about cpp-linter-action HOT 13 CLOSED

OK, this needs much effort. I just realized if their code is hosted on GitHub why not use GitHub Actions 🤪

from cpp-linter-action.

So you prefer to transfer to cpp-linter org?

If we transferred, I can also do the following steps to minimize the impact

1. use my account to fork cpp-linter/cpp-linter-action
2. update the child repo README deprecated, add a link to the parent repo
3. then make the child repo shenxianpeng/cpp-linter-action as archived

from cpp-linter-action.

If you want to transfer the repo, then wait till the PRs are closed or merged because I've heard horror stories about transferring repos with open PRs.

from cpp-linter-action.

Funny you opened this just now. I'm in the process of opening a PR to merge the needed modifications for windows-based runners. I'm literally in the process of updating the README for Windows-based runners.

As for using this code on other CI services (non-github), I think a fork of this repo is currently required since this action's src code heavily relies on github-specific env vars. While similar env vars might be available on other CI services, they might be named differently (which is a breaking point).

It would take a lot more research and testing to adapt the source code for other CI services' env vars, but it is definitely possible. I don't have a bitbucket account, but I do have a gitlab account (never really used though) and a travisCI account (haven't used it in years though).

from cpp-linter-action.

It is a good idea though. I didn't think to use it for other CI services like this. Additionally, this is starting to address one of your original design goals: Make it compatible with bitbucket pipelines.

Now that we can take advantage of python, I think this idea is better than maintaining a different fork for each CI service.

from cpp-linter-action.

I think this idea is better than maintaining a different fork for each CI service.

That's true. In terms of the name of the repo and what it's going to do, my option don't want to make it too 'big'. It's just an Action focused on GitHub.

If support other CI services, it might better to have an org like cpp-linter (I created one before https://github.com/cpp-linter) with a cpp-linter repository underneath it, which supports calls like this.

python3 -m cpp_linter.run --ci=action --ignore=build --database=build --thread-comments=true
python3 -m cpp_linter.run --ci=jenkins --ignore=build --database=build --thread-comments=true
python3 -m cpp_linter.run --ci=bitbucket --ignore=build --database=build --thread-comments=true

I have stopped maintaining bitbucket internally, and the lack of easy integration is one of the reasons.

If users can use cpp-linter in this way in the future, leave the rest to cpp_linter.run, it would be convenient.

Then the current source code folder cpp_linter can be moved from shenxianpeng/cpp-linter-action to cpp-linter/cpp-linter. then this cpp-linter-action can install linter python package with python3 -m pip install git+https://github.com/cpp-linter/cpp-linter

This allows us to maintain one repository instead of multiple.

Under cpp-linter organization, there may also be these repos

• cpp-linter-jenkins - provide integration with Jenkins or examples
• cpp-linter-bitbucket - provide integration with Bitbucket or examples
• etc.

These are just some of my immature thoughts ...

from cpp-linter-action.

Close it. Please feel free to reopen when there is a further plan.

from cpp-linter-action.

Then the current source code folder cpp_linter can be moved from shenxianpeng/cpp-linter-action to cpp-linter/cpp-linter. then this cpp-linter-action can install linter python package with python3 -m pip install git+https://github.com/cpp-linter/cpp-linter

I can tell you from experience that transferring the repo from one account to another will not screw up existing workflows that still use the old account. Github does some clever redirecting in the event of repo transfers, although that might be limited to a year or so.

from cpp-linter-action.

OK, let's wait until PRs are merged.

from cpp-linter-action.

1. use my account to fork cpp-linter/cpp-linter-action

2. update the child repo README deprecated, add a link to the parent repo

3. then make the child repo shenxianpeng/cpp-linter-action as archived

I think making this repo into an archived fork of the transferred repo is a bad idea. It might confuse github into disabling the auto-redirect behavior. Not to mention confusing people about which action code is actually being used (archived or not).

from cpp-linter-action.

Technically, you could also transfer the docker image repo to the @cpp-linter org as well. I'm not sure if that would have implications on dockerhub though.

from cpp-linter-action.

Thank you for your suggestions. I'm going to transfer, and it seems need necessary changes after transfered

from cpp-linter-action.

I created a branch named transfer-update for transfer ownership update.

from cpp-linter-action.