Missing public `OutputType` about xcbeautify HOT 5 OPEN

Hi @swiftyfinch.

Thanks for being an xcbeautify user, and sorry for the delayed response!

I internalized OutputType, since I wanted this to be an implementation detail, similar to most of the other types.

In the future, my intention has been to simply read a string and output an optional (formatted) string via Xcbeauitier.

Recently, I introduced a protocol called OutputRendering. Its concrete types are meant to be custom formatters, and I think that might address your use case.

Have you looked into this, and what do you think about creating one to solve this issue?

I’d like to avoid re-exposing other types as public, since it’ll slow down some of the otherwise breaking changes I’ve been planning to make, but I’m open to other ideas.

Let me know what you think, and we can find a way to continue supporting your use case.

from xcbeautify.

@cpisciotta Oh, I see.
I will give it a try when I have some free time.
Thank you for the suggestion!

from xcbeautify.

@swiftyfinch No problem! Let me know how I can help.

from xcbeautify.

@cpisciotta I'm sorry, I'm not sure I understand what you mean.
Do you want to open OutputRendering protocol?

If so, it would look like this:

public protocol OutputRendering { ... }

public enum Renderer: String {
    ...

    /// Any custom render
    case custom(OutputRendering)
}

XCBeautifier(renderer: .custom(MyRender())).format(line: "something")

And then, any user can provide a custom render.
This is not as simple as just opening OutputType, but it is quite flexible.

However, there is a downside - it requires opening a lot of *Capture types and their properties in order to allow for custom renders. For example, ErrorCaptureGroup.

public protocol ErrorCaptureGroup: CaptureGroup {
    var wholeError: String { get }
}

struct MyRender: OutputRendering {
    func formatError(group: ErrorCaptureGroup) -> String {
        let errorMessage = group.wholeError
        return ... // custom implementation
    }
}

Did I understand you correctly?

from xcbeautify.

@swiftyfinch Not quite. I am asking if you'd be open to implementing a "Rugby-style" formatter directly in the xcbeautify project. It would obviously be consumed by Rugby, but because it'd be in the project, it could be used by others too.

from xcbeautify.