property withCross of the Modal about cozy-ui HOT 10 CLOSED

🎉 👍
I made this branch a long time ago but I never pull-requested it. Please take all you need from it. https://github.com/gregorylegarec/cozy-ui/commits/feat/deprecate-modal-withcross

I took a particular attention to keep the code compatible with the use of withCross.

from cozy-ui.

I agree that the naming is bad.

To me a modal should be closable=true by default. The closable property would also control that the close button is shown and that the modal can be closed by clicking outside.

from cozy-ui.

On your properties withClosingButton and disallowClosing : I do not understand the interaction between your properties and am generally in favor of reducing the API of a component.

@ptbrowne I agree but I could need the clickoutside without the cross button if the cross button is already handled by the intent itself.

from cozy-ui.

@ptbrowne Yep

from cozy-ui.

On your properties withClosingButton and disallowClosing : I do not understand the interaction between your properties and am generally in favor of reducing the API of a component.

For example with your names, what happens when disallowClosing=true and withClosingButton=true ?

from cozy-ui.

@enguerran It seems to me by looking at the history that you added the withCross property. What do you think ?

from cozy-ui.

I think THERE IS NO NEED for uppercase in issue content.
Nevertheless, I can remember I added that when I was working on very short deadline (#78) and it was good enough in those dark times.
But usage and experience may teach different conclusions and I guess it would be good to upgrade this API.

Let write down a standalone version in the styleguide and see/expose the different and exhaustive wanted usages.

from cozy-ui.

@ptbrowne It is old stuff, but I remember having identified a case where a modal should not be closeable in other way than choosing for two options. But if it's not needed right now let's remove this feature and focus on renaming this prop while keeping retro-compatibility. Go for a pull-request @CPatchane :)

from cozy-ui.

@ptbrowne It is old stuff, but I remember having identified a case where a modal should not be closeable in other way than choosing for two options.

So it is closable=false right ?

from cozy-ui.

Closed via #237

from cozy-ui.