Git Product home page Git Product logo

Comments (6)

jeremyphilemon avatar jeremyphilemon commented on April 30, 2024

@shuklaayush hey can you look at this?

from covid19india-react.

sudevschiz avatar sudevschiz commented on April 30, 2024

@steffyjohn Seems fine for me. Can you elaborate?

from covid19india-react.

shuklaayush avatar shuklaayush commented on April 30, 2024

I think the issue is that the state colours are assigned directly from a continuous colour space, while the legend is a sampled version of the colour space. Hence, there's the possibility of a mismatch. We can either switch to a continuous legend, or assign colours from the sampled colour space. Any thoughts?

from covid19india-react.

jeremyphilemon avatar jeremyphilemon commented on April 30, 2024

@shuklaayush You're right, the colors on the map are based on a scaling factor, I think it'd be appropriate if the legend used the same too!

Let me know if you'd like me to assign you for this fix!

from covid19india-react.

shuklaayush avatar shuklaayush commented on April 30, 2024

@jeremyphilemon The legend is already scaled as well. I think the issue is rather that the legend is a fixed set of 6 coloured blocks instead of a continuous scale. Right now, the fixed colour is the colour of the lower bound of the range.

What do you think about this?

Screenshot from 2020-03-25 14-26-34

from covid19india-react.

jeremyphilemon avatar jeremyphilemon commented on April 30, 2024

Patched #51

from covid19india-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.