Replace all instances of `lock(this)` about couchbase-lite-net HOT 2 CLOSED

@zgramana is this still needed? I inspected the code and found a small number of occurrences. Most of them are related to Task, TaskFuture and ScheduledThreadExecutor (all in the Sharpen namespace). I am not sure if these classes are going to be used much longer as it seems that you already make use of the TPL on other areas of the library (btw, no Rx?) :)

from couchbase-lite-net.

This comment turned into a bit of a brain dump. TL;DR, you're correct, this issue can be closed.

As you noted, I've fixed most of the converted code with the exception of the Sharpen helper classes. The goal is to ultimate replace the helpers with idiomatic .NET. Most of those files aren't used anyway.

As far as Rx goes, I've been looking for project to use it with, but I'm pretty conservative when it comes to adding dependencies to library projects. That, and I don't have much time in the cockpit with Rx, so to speak. I'm even reluctant to use async/await much in this library, as I want to impose as little on downstream consumers as possible.

That said, once the vanilla stuff is working, I'm very interested in seeing how we can better flex .NET. I think there maybe an opportunity to expose a late-evaluated, late-materialized LINQ context. We might also be able to use TPL Dataflow to better handle concurrency, and write/read ordering.

from couchbase-lite-net.