Add cw20 support to atomic swap contract about cw-plus HOT 6 CLOSED

There are some FIXME? in the code: basically, what if somebody sents a non-empty array of native coins, or a cw20 coin, but sets their amounts to zero? Do we need to check / reject those messages, or are they rejected by the SDK?

Another question: Is it worth it to improve the logs a little? Log the sender and amounts on creation, by example.

from cw-plus.

Sure. #76 created.

from cw-plus.

Initial implementation is under the cw20-atomic-swaps branch. Unit tests to follow; PR to follow after it.

I implemented functionality for the two tokens (native vs. cw20) into the same functions, for simplicity and consistency. Can separate them into different functions for clarity if you think it's worth it.

from cw-plus.

PR: #72.

from cw-plus.

Counting zero amounts as missing is a good check. I would filter out zeros in the native coins, and then ensure it has length >0 and only save the filtered list.

For cw20 coins, yeah, rejecting 0 amounts sounds good. We should also reject such sends in cw20-base. Can you make an issue for that?

from cw-plus.

Closed by #72

from cw-plus.