Git Product home page Git Product logo

Comments (7)

coryhouse avatar coryhouse commented on May 4, 2024

Great point. I just replaced the arrow func with an anonymous function. Can you please try again and confirm you're good? I did not intend to use ES6 features in the build tools. I want to assure older versions of Node can run this. Thanks for reporting this!

from react-slingshot.

Guibod avatar Guibod commented on May 4, 2024

Tested today on ubuntu with nodejs 0.10, it just won't work.
See webpack-contrib/css-loader#144 (comment)

ERROR in ./~/css-loader!./~/sass-loader!./src/styles/styles.scss
Module build failed: ReferenceError: Promise is not defined
    at LazyResult.async (/home/user/dev/webapp/node_modules/css-loader/node_modules/postcss/lib/lazy-result.js:157:31)
    at LazyResult.then (/home/user/dev/webapp/node_modules/css-loader/node_modules/postcss/lib/lazy-result.js:79:21)
    at processCss (/home/user/dev/webapp/node_modules/css-loader/lib/processCss.js:198:5)
    at Object.module.exports (/home/user/dev/webapp/node_modules/css-loader/lib/loader.js:24:2)
 @ ./src/styles/styles.scss 4:14-123 13:2-17:4 14:20-129

from react-slingshot.

coryhouse avatar coryhouse commented on May 4, 2024

Thanks guys - I'm still trying to determine the minimum Node version this currently supports as is. Do you have a suggestion for an easy way to figure that out?

.10 is quite old as it was released nearly 3 years ago: 2013-03-11. I can add the promise polyfill, but I hate to add another dependency to fix an issue on a 3 year old release. Enlighten me - Is there a good reason to support versions this old? Since this is a framework for new development, wouldn't someone logically want to utilize a recent version of Node as well? Certainly open to a dialog on this.

from react-slingshot.

Guibod avatar Guibod commented on May 4, 2024

0.10 is in used in Ubuntu since the very beginning of the package. Next release (Xenial) is jumping to Node 4.2.4 (see http://packages.ubuntu.com/search?keywords=nodejs )

You're on the bleeding edge of software development, you don't have to support back compatibility. It's up to you to define the minimum requirements.

I strongly suggest that you enhance the README with this minimal requirement and point a friendly mean of installing up-to-date NodeJs implementation. For instance https://github.com/nodesource/distributions

Your starter kit is intended for developer audience. You can assume that we are capable of installing a fixed version of node to match the kit.

from react-slingshot.

coryhouse avatar coryhouse commented on May 4, 2024

Thanks for the advice. Makes sense. So you're saying if I set requirements at 4.2.4, those on Linux should still be able to use this?

from react-slingshot.

jcpst avatar jcpst commented on May 4, 2024

The official node site has good information on installing node v4 and v5 on various Linux distros: https://nodejs.org/en/download/package-manager/

Also, anyone doing regular node dev work would likely want a node version manager (like nvm).

from react-slingshot.

coryhouse avatar coryhouse commented on May 4, 2024

I've noted 4.0.0 as the minimum version in the Readme. Thanks for the input everyone!

from react-slingshot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.