Comments (2)
@joonathan thank you for the bug report, I have found the issue and I a working on a fix.
I am confused that this does not seem to happen in Python != 2.7.9. I don't believe there were any backwards incompatible changes in the 2.7.9 released two days ago.
That said, I have simplified the decorator, so it no longer causes this problem, and is even more readable :-)
PR for reference #85
from flask-cors.
While I was able to repro this by upgrading a virtualenv, I am not able to replicate this in a clean install of 2.7.9. Looking at that stack trace, it looks like something wacky is going on with virtualenv. That stack trace spans multiple Python paths. I was able to cause a similar one:
Traceback (most recent call last):
File "/Users/Cory/Development/flask-cors/tests/test_exception_interception.py", line 75, in test_acl_abort_500
resp = self.get('/test_acl_abort_500')
File "/Users/Cory/Development/flask-cors/tests/base_test.py", line 53, in get
return self._request('get', *args, **kwargs)
File "/Users/Cory/Development/flask-cors/tests/base_test.py", line 50, in _request
return getattr(c, verb)(*args, **kwargs)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/werkzeug/test.py", line 762, in get
return self.open(*args, **kw)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/flask/testing.py", line 108, in open
follow_redirects=follow_redirects)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/werkzeug/test.py", line 736, in open
response = self.run_wsgi_app(environ, buffered=buffered)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/werkzeug/test.py", line 659, in run_wsgi_app
rv = run_wsgi_app(self.application, environ, buffered=buffered)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/werkzeug/test.py", line 855, in run_wsgi_app
app_iter = app(environ, start_response)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/Cory/Development/flask-cors/.env/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/Users/Cory/Development/flask-cors/flask_cors.py", line 270, in decorator
return update_wrapper(wrapped_function, f)
File "/usr/local/Cellar/python/2.7.8_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/functools.py", line 33, in update_wrapper
setattr(wrapper, attr, getattr(wrapped, attr))
AttributeError: 'exceptions.AttributeError' object has no attribute '__module__'
I am hopeful that this issue does not occur on a clean install of Python, fingers crossed it is just a OSX issue with virtualenv. I wish my automated testing had caught this! (Looks like Travis CI is still on 2.7.8)
Sorry for the trouble and thanks again for the awesome report!
from flask-cors.
Related Issues (20)
- enforcing same origin policy with flask-cors HOT 14
- Next.JS API Call to Flask API POST Endpoint - `Access-Control-Allow-Credentials` is not set properly
- Package prints unexpected DEBUG messages when app runs HOT 2
- Unknown keyword arguments silently ignored HOT 2
- Want to know the next version update time. HOT 1
- Project is dead? HOT 2
- CORS partially fails when making requests with axios in React HOT 3
- Access to fetch at 'http://127.0.0.1:5000/account/summary' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. HOT 2
- v4.0.0 isn't in CHANGELOG.md HOT 1
- two releases 4.0.0 and v4.0.0 HOT 2
- All private network requests unintentionally allowed
- Random Access-Control-Allow-Origin value being returned if Origin request header is not provided HOT 1
- The `4.0.0` release is incorrectly marked as supporting Python 2
- Who to contact for security issues HOT 2
- appropriate citation for the module? HOT 3
- python 3.12 HOT 2
- CORS issue HOT 1
- Read the Docs is configured to build from a non-existent branch HOT 2
- CVE-2024-1681 response/patching HOT 2
- Security Issue CVE-2024-1681 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flask-cors.