Comments (11)
No effort then from the maintainers of the library
from cornerstone3d.
Personally & honestly I'm tired to try to fix this library while I don't have time for that and don't know this one as well as the official developers of this one. So, nop... Sorry... I'm tired! I prefer to stay stuck at the latest functional version instead of updating to a shit version!
from cornerstone3d.
Apologies for the delayed response.
While the error message may appear similar, the code snippet provided may not address the underlying cause of this bug. Also I am not certain about the steps that led to this issue.
However, I've created a new bug (#1270) that can be resolved using the proposed modification mentioned earlier. I'd appreciate it if you could review it and let me know your thoughts. If you agree with the modification, I can proceed to create a merge request.
from cornerstone3d.
@Sanoj-thomas I will check it in the other issue thanks
from cornerstone3d.
@Sanoj-thomas I will check it in the other issue thanks
Hi @sedghi,
I recently updated from 1.4x cornerstone and this bug breaks our implementation of cornerstone. The problem is in update 1.71.5 when getFrameOfReferenceId function was changed to include getImagePlaneReferenceData.
cornerstone3D/packages/core/src/RenderingEngine/StackViewport.ts
Lines 509 to 515 in 8f84147
The documentation indicates when an image doesn't have imagePlaneModule metadata, it returns undefined. This is not true anymore and breaks existing implementations.
/**
* Returns the frame of reference UID, if the image doesn't have imagePlaneModule
* metadata, it returns undefined, otherwise, frameOfReferenceUID is returned.
* @returns frameOfReferenceUID : string representing frame of reference id
*/
I created a pull request that checks if imagePlaneModule metadata exists and exits without trying to destructure an undefined imagePlaneModule.
if you have time, would you mind reviewing or providing feedback to get this issue resolved.
it should resolve this issue along with #1272 , #1270
from cornerstone3d.
Hi, I have the same issue, have you found a solution?
from cornerstone3d.
Thanks for the reply. Guess I'll stick to the lower version, hope that doesn't cause problems down the line.
from cornerstone3d.
You need to provide more info, screenshot, video or anything else other than (load dicom)
from cornerstone3d.
@sedghi
Could you please confirm whether we need a null/undefined check here .
Current code:
const imagePlaneModule = metaData.get(MetadataModules.IMAGE_PLANE, imageId);
const { imagePositionPatient, frameOfReferenceUID: FrameOfReferenceUID } = imagePlaneModule;
Modified code
const imagePlaneModule = metaData.get(MetadataModules.IMAGE_PLANE, imageId);
if(!imagePlaneModule){
return;
}
const { imagePositionPatient, frameOfReferenceUID: FrameOfReferenceUID } = imagePlaneModule;
If somehow 'IMAGE_PLANE' metadata is missing while fetching the frameOfReferenceUID following error may be logged.
Cannot destructure property 'imagePositionPatient' of 'imagePlaneModule' as it is undefined.
Please confirm.
from cornerstone3d.
@Sanoj-thomas is this related to this issue number 1174?
from cornerstone3d.
Thanks @heyflynn I merged your PR, so I will close this issue
from cornerstone3d.
Related Issues (20)
- [Bug] StackViewport not cancelling scroll debounce timer when the Image Set is not fully Loaded HOT 1
- [Bug] Desired resource size is greater than max texture size HOT 2
- [Bug] Issue in runtime useing @vue/cli-service building tool after upgrade cornerstone libs. HOT 2
- [Bug] Contour's color is wrong HOT 17
- Nifti scroll problem
- [Bug] Memory Leaks on inter cpu computer HOT 3
- [Bug] Volume viewport synchronization - Couldn't handle volume viewport synchronization for different viewports (Sagittal, axial and coronal)) HOT 3
- [Bug] After using compression, DICOM files rendereed as brighter HOT 2
- [Bug] When using @cornerstonejs/tools with electron or SPA Vue+vite, production application crash HOT 3
- [Bug] generateVolumePropsFromImageIds allocates an Int16Array if rescale or intercept is negative, which is incompatible with texSubImage3D HOT 1
- [Feature Request] How do I render a TAG pixel in Dicom with a TAG Value of 6000,3000 HOT 6
- Image Loader - cancelLoadAll() errors when no imageId's in request pool. HOT 1
- [Bug] When I have a lot of contourSegments displayed, the pagination of the image becomes sluggish HOT 1
- [Bug] 使用volumeLoader.registerVolumeLoader("nifti", cornerstoneNiftiImageVolumeLoader);加载图像出现Bug HOT 2
- [Bug] How to resolve "Multiple segmentation representations detected for this tool group. The first one will be used." HOT 1
- [Bug] First image rendered by the volume loader is not the first instance in series HOT 2
- [Bug] fix(metaData Types): change { any } to any type HOT 1
- [Bug] StackViewport.setImageIdIndex should set this.targetImageIdIndex too HOT 2
- Image display blur
- Rendering .nii file error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cornerstone3d.