Git Product home page Git Product logo

Comments (1)

mrlnc avatar mrlnc commented on July 25, 2024

navigate_to_dest does the URL handling (both updating URL and reading URL and jumping to the location). It takes two arguments:

/**
   * @param{string} detail_str may come from user provided hashtag, need sanitizing
   * @param{Page=} src_page page containing the source event (e.g. link)
   */
            navigate_to_dest: function(detail_str, src_page) {

Some calls to the function are missing the second argument:

if (this.config['hashchange_handler']) {
    window.addEventListener('hashchange', function(e) {
          self.navigate_to_dest(document.location.hash.substring(1));
    }, false);
}

if (this.config['view_history_handler']) {
     window.addEventListener('popstate', function(e) {
          if (e.state) self.navigate_to_dest(e.state);
    }, false);
}

To fix the URL handling, src_page must be set to document.location.

Maybe this patch will do: mrlnc@9788c33 untested because build seems currently broken #17

from spex-3gpp.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.