make LessThan, Equal and Compare accept a pointer type about go-semver HOT 3 OPEN

Because right now, I can't write for example foo.Compare(semver.New("1.2.3")). I know, I could just use foo.String() == "1.2.3". But I think it would make sense to accept whatever type the "constructor" (New()) returns, especially as it comes at no cost.

Regarding the receiver type, the link you provided also says:

Next is consistency. If some of the methods of the type must have pointer receivers, the rest should too, so the method set is consistent regardless of how the type is used.

The go vet tool (or maybe go lint) even complains about differing receiver types.

from go-semver.

from go-semver.

Because right now, I can't write for example foo.Compare(semver.New("1.2.3")). I know, I could just use foo.String() == "1.2.3".

foo.Compare(*semver.New("1.2.3")) works fine

But I think it would make sense to accept whatever type the "constructor" (New()) returns,

Fair point, although arguably the current situation is a bit more flexible (because you can dereference inline but not reference inline).

Regarding the receiver type, the link you provided also says:

hoisted by my own petard ;-). IMO the current situation is still cleaner but if you feel really really strongly about it you could put up a PR

The go vet tool (or maybe go lint) even complains about differing receiver types.

Strange, I can't seem to reproduce

from go-semver.