error when description is empty string about yang-js HOT 9 CLOSED

Yes, I've noticed that as well. I suppose an empty string is technically valid, but it seems like it defeats the purpose of defining a description statement in the schema if it's not going to contain any meaningful value.

from yang-js.

True. But I am not the one writing these yangs :)

from yang-js.

What YANG module has this? Let me loop in @llhotka to get his thoughts on dealing with this.

from yang-js.

Empty description should be possible, I will check the parsing rules.

from yang-js.

The parser seems to accept empty descriptions, both single- and double quoted.

from yang-js.

Example yang with this:
https://github.com/YangModels/yang/blob/master/vendor/cisco/xr/611/Cisco-IOS-XR-ipv4-bgp-oper-sub1.yang

from yang-js.

No problem on the parser side:

$ coffee check_submodule.coffee Cisco-IOS-XR-ipv4-bgp-oper-sub1.yang 
Submodule OK.

from yang-js.

Thanks @llhotka for your verification. The issue is on yang-js side, it is enforcing that the argument exists... I'll fix on my end.

from yang-js.

@llhotka - the issue is that the parser currently returns an empty string both for when the argument is an empty string and when there is no argument.

coffee> parser = require 'yang-parser'
coffee> parser.parse 'description "";'
YangStatement { prf: '', kw: 'description', arg: '', substmts: [] }
coffee> parser.parse 'description;'
YangStatement { prf: '', kw: 'description', arg: '', substmts: [] }
coffee> parser.parse 'input {}'
YangStatement { prf: '', kw: 'input', arg: '', substmts: [] }
coffee> parser.parse 'input "" {}'
YangStatement { prf: '', kw: 'input', arg: '', substmts: [] }

I was previously treating empty arg string as non-existence which was presenting the issue as described in this ticket. If I allow empty arg string from the yang-parser then I will need a way to differentiate between a legitimate empty arg string vs undefined argument. Can you have the yang-parser return arg: undefined/null if no argument found during parsing?

from yang-js.