Diamond shaped stores... about xnethack HOT 4 CLOSED

I consider this not a bug with themed rooms but a latent problem with vanilla that assumed shops would always be rectangles of minimum size 3x2. Basically, the algorithm for deciding whether a room is valid to place a shop in does not account for rooms having only 1 square inside the door, and I believe these should be considered invalid.

First, I need to reproduce this in vanilla with the "Circular, small" themed room, then I will work on a vanilla patch that fixes it, and will keep this issue open until the fix is merged into xNetHack.

from xnethack.

OK - this doesn't appear with the Circular small room as I predicted. Is it instead this room (unique to xNetHack)?

    ---    
    |.|    
   --.--   
  --...--  
---.....---
|.........|
---.....---
  --...--  
   --.--   
    |.|    
    ---    

In this room, a shopkeeper is indeed unable to move out of your way. But the underlying problem is the same - if vanilla decided to add this room they'd have the same problem. The adjustment to the algorithm is a little more complicated though.

Submitted the fix as NetHack/NetHack#888.

from xnethack.

That's the shape I encountered. Quite frustrating given it was the only store in the game (other than Izzy's) after +20k moves and, of course, undiggable walls...

from xnethack.

Should be fixed as of the recent vanilla merge.

from xnethack.