macOS build failed about xnethack HOT 3 CLOSED

For MacOS, try running

./sys/unix/setup.sh sys/unix/hints/macOS.370
make fetch-lua
make all
make install

Instead of that install file. The typical build path for unix is to run those commands, with the only thing being swapped out is the sys/unix/hints/PATHNAME hints file to actually run. Note: I don't use MacOS anymore, but I'm getting this off how I compile on ubuntu and the travis build workflow for this repo, link.

from xnethack.

This is a known issue that should be fixed with the next vanilla merge. The vanilla fix is in commit NetHack/NetHack@1302814. You can try applying that change yourself in the meantime, it's pretty straightforward. You just add && !defined(MACOS) so that __warn_unused_result__ and warn_unused_result aren't "blanked out" in tradstdc.h:

diff --git a/include/tradstdc.h b/include/tradstdc.h
index 8c33d55e0..ee6bd99c2 100644
--- a/include/tradstdc.h
+++ b/include/tradstdc.h
@@ -405,7 +405,7 @@ typedef genericptr genericptr_t; /* (void *) or (char *) */
 #if __GNUC__ >= 3
 #define UNUSED __attribute__((unused))
 #define NORETURN __attribute__((noreturn))
-#if !defined(__linux__) || defined(GCC_URWARN)
+#if (!defined(__linux__) && !defined(MACOS)) || defined(GCC_URWARN)
 /* disable gcc's __attribute__((__warn_unused_result__)) since explicitly
    discarding the result by casting to (void) is not accepted as a 'use' */
 #define __warn_unused_result__ /*empty*/

from xnethack.

Thank you very much. Applying the patch worked. Now I can compile

from xnethack.