Comments (5)
done in v3
from node-pool.
@sandfox I'm trying to take a shot at it because my other PR is finished but I cannot run the expresso tests on Windows. However I don't understand the tests at all, some inline documents would have been helpful. There is no such thing as beforeExit
and mocha, instead you call done
with either an error or without one for async tests. The way you iterate synchronously with a for
loop and then trigger async actions and the assert synchronously doesn't make sense to me...
Maybe you have some input, otherwise I will just take the existing test descriptions and write new ones for them, make them pass on the current version and then test against my prototype-PR.
from node-pool.
But I'm not even sure what expands to max limit even means - what is it in this context?
from node-pool.
Btw mocha needs at least Node 0.8, which means we cannot test on Travis for Node 0.2 anymore.
from node-pool.
Ok, I'll have a look and see if I shed any further light on that stuff and drop it here
I'm totally fine with dropping testing for everything pre-0.8 - as long as the new tests pass I'm happy with line of reasoning that we haven't broken backwards compatibility for library consumers (which ever ones are still out there on old skool node versions), and when the "class" stuff lands, as long as the tests still pass then in theory we still won't have broken b/c.
from node-pool.
Related Issues (20)
- waitingClientsCount function has disappeared HOT 1
- resource release not getting called HOT 2
- NPM installation faliure HOT 2
- Add param to factory
- Feature: add pool.use method. HOT 1
- Borrowed resources never go higher than 1 HOT 2
- Share pool between servers in a cluster HOT 3
- How to work maxWaitingClients? HOT 1
- Add destroy timeout to prevent pool.clear from hanging when destroy promise never resolves HOT 4
- testOnReturn = no-op?
- What does happen if I don't release the resource and close the node? HOT 2
- Resource not currently part of this pool HOT 1
- `ready` method from Pool is missing from the TS definitions (v3.8.2)
- .use does not handle synchronous work functions
- Consistently occuring `ResourceRequest timed out` Error HOT 1
- TimeoutError: ResourceRequest timed out HOT 2
- Suggested Feature: borrowTimeoutMillis HOT 2
- Pool does not maintain the minimum HOT 1
- Suggestion on softEvictConnections
- AutoStart Completion Callback HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-pool.