IcedCoffeeScript callbacks incompatible with support for legacy single-argument callbacks to acquire about node-pool HOT 5 CLOSED

It is incompatible with flow control libraries like "node-seq". Simply it recognizes returned object as error.
In my opinion we (as programmers) should have an option to turn off that behavior.

from node-pool.

Ok, I just committed a patch that removes adjustCallback() -- I haven't pushed this to npm yet. If you have time, please grab this change from master and try it in your app and let me know if it works. If so I'll release this as 2.0.0 (to indicate that the change is not backwards compatible).

from node-pool.

Sorry for my "lag" in response but I was really busy.
BTW Of course it works for me! :)
But I found a slightly strange case. Function "createResource" attempt to make something "similar" to "adjustCallback".

    var Pool = require('generic-pool');
    var p = Pool.Pool({
            name: "mysql",
            create: function (callback) {
                    var o = {'test':1};
                    callback(o);
            },
            destroy: function (client) {
            },
            max: 20,
            idleTimeoutMillis: 100
    });

    p.acquire(function(error) {
            console.log(arguments); // 0 = null, 1 - my test object
    });

Are You really sure that is correct and expected (for everyone) behavior?

from node-pool.

After longer reflection I think the above behavior is correct :)

from node-pool.

Ok, great. I just published a 2.0.0 release to npm.

thanks!

-- James

On Wed, Jul 25, 2012 at 11:49 PM, Łukasz Kużyński <
[email protected]

wrote:

After longer reflection I think the above behavior is correct :)

---

Reply to this email directly or view it on GitHub:
#32 (comment)

James Cooper
http://blog.bitmechanic.com/

from node-pool.