destroy() should probably call dispense() about node-pool HOT 6 CLOSED

I am implementing this library in my project, and because I was only using release() I had issues with corrupt connections being constantly reused. Given that this github issue is not yet resolved, is it safe to call destroy()?

from node-pool.

Do you have a minimal repro of the problem you're seeing? I don't think it's related to this issue, as it sounds like you're getting closed resources returned by dispense()?

The impact of this issue is that if destroy() is called manually on a full pull with waiting callers, the waiting callers will not be notified.

But typically you'll call release(), not destroy(), so this is probably not an issue for most systems.

from node-pool.

Ahh, thanks for helping me understand the impact. That makes sense.

Here is a gist with my code, that requires you to have Oracle XE and the Oracle Instant Client installed: https://gist.github.com/raztus/6242411. That example simply queries the DB repeatedly. While it's running, if the Oracle server is restarted, the connection returns the error Error: ORA-03114: not connected to ORACLE. Forever more, that connection is corrupt but will never be destroyed, since it's being reused.

from node-pool.

So in the currently published version (2.04), if I need to manually remove a corrupted client, I should call both destroy and then dispense?

pool.acquire(function(err, client) {
  if (err) {
    console.dir(err)
    return 
  }
  // something is wrong with the client and it should be destroyed
  pool.destroy(client)
  pool.dispense() // is this line needed?
})

from node-pool.

Is this thing still valid?

from node-pool.

this is now dodged/removed by the work in v3.

from node-pool.