.drain() doesn't clear timeouts about node-pool HOT 7 CLOSED

Seems calling .drain() and .destoryAllNow() together makes node-pool quit reasonably fast. It still waits for one reapInterval though.

from node-pool.

Interesting. Do you have a suggested fix? Or perhaps a failing unit test? That would help me reason through the solution.

from node-pool.

The reason I reported this is that node-pool prevents my tests from exiting cleanly in a timely fashion. I suggest savig the setTimeout's return value and calling clearTimeout when draining the pool.

from node-pool.

I actually missed this issue, but I ran into the same problem and submitted pull request #37 that fixes this.

from node-pool.

By the way, the clearing of the reap timeout belongs in destroyAllNow instead of drain because dain just waits for all objects to be returned to the pool and the reap timeout needs to be live when there are objects idle in the pool. destroyAllNow actually destroys all the objects, so since there are no longer objects to reap after a destroyAllNow then the timer can just be canceled. The following is how I end my node scripts with the pool:

pool.drain(function () {
    pool.destoryAllNow();
    // Now just waiting for no events on the even loop & exit with code 0
});

from node-pool.

@kkaefer this issue looks closed, right?

from node-pool.

closing this as it looks fixed in #37

from node-pool.