Comments (5)
Seems good, maybe output the previous and existing policy and confirm? Offer a –y option to skip.
-Erik
From: Yuva Shankar <[email protected]mailto:[email protected]>
Reply-To: contiv/volplugin <[email protected]mailto:[email protected]>
Date: Wednesday, October 26, 2016 at 10:55 AM
To: contiv/volplugin <[email protected]mailto:[email protected]>
Subject: [contiv/volplugin] Multiple policies with the same name (#469)
When a policy with same name is uploaded twice, the user should be informed about the existing policy otherwise it leaves an impression that the new policy is in use which is not the case!
[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy1.json
[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy2.json
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/469, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ61Qdsik6qJ4yVRKc0MgbakIdz8R_ks5q35QigaJpZM4KheZX.
from volplugin.
So when someone uploads a new policy with the same name, it will affect all the existing volumes under that policy. I suppose we should not allow this operation itself. WDYT?
from volplugin.
no, it will only affect the new volumes.
look at hte runtime upload option for how to affect volumes at runtime.
from volplugin.
That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.
from volplugin.
This is what the policy archive is for; it can trace back these changes.
From: Yuva Shankar <[email protected]mailto:[email protected]>
Reply-To: contiv/volplugin <[email protected]mailto:[email protected]>
Date: Wednesday, October 26, 2016 at 5:21 PM
To: contiv/volplugin <[email protected]mailto:[email protected]>
Cc: Erik Hollensbe <[email protected]mailto:[email protected]>, Comment <[email protected]mailto:[email protected]>
Subject: Re: [contiv/volplugin] Multiple policies with the same name (#469)
That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//issues/469#issuecomment-256513834, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ6_GbHzxdP4QkzOr3yGCdR9_RwsaDks5q3-6AgaJpZM4KheZX.
from volplugin.
Related Issues (20)
- Taking volume snapshot - Snapshot timestamp is not returned by the endpoint
- volsupervisor does not free locks if it is terminated during snapshot operations HOT 21
- Unable to create volume with the same name as the one deleted.
- Integrate a dead code checker into checks.sh
- Convert API server to use `api` package where applicable
- Integrate misspell into checks.sh
- use govalidator in structs
- Remove "demo mode"
- Volume list command logic fix HOT 2
- Pretty all json responses in volcli HOT 2
- Policy validation generates an unhelpful error when "size" doesn't contain a unit
- Fix Mount() to call ApplyCGroupRateLimit as appropriate.
- Cleanup log messages HOT 3
- container launch fails to create rbd volume HOT 6
- removing volumes with snapshots breaks volume remove
- Allow ceph driver to specify --id
- Implement rbd-nbd as mapping commands
- Getting Started link in README.md is broken HOT 1
- Documentation for volplugin missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from volplugin.