Git Product home page Git Product logo

Comments (4)

gui-santos avatar gui-santos commented on June 18, 2024 1

Wouldn't the user have to click into the field to type anyway? I counted the same number of actions. Even in the case of two consecutive queries, the user would:

Of course!!! 🤦
@domarku you're 100% right... I totally missed this hahaha

So yeah! For me, this is a good proposal we should do it
thanks a lot!

from forma-36.

gui-santos avatar gui-santos commented on June 18, 2024

Hey @domarku

I like your proposal to change the navigation. I believe it would be a great improvement :)

I'm thinking that the person visiting the docs would have to click the icon and then search. And then if you search something else after that, it's another click + type
What do you think about exposing the search in the bar and having it always there? So the user just needs to type and they get the results

And I made two quick alternatives for the hover and active states

Screenshot 2020-04-23 at 11 43 24

I've just used the hover color we have set for the DropdownListItem (The contrast of this hover will be increased soon once we change the color palette)
And I added that blue bar trying to mimic the active state of the Tab component

Screenshot 2020-04-23 at 11 36 57
In this one, we do the same for the hover state, but the active state is the same that you did I've just used the lightest blue.... but Idk

What do you think?

from forma-36.

domarku avatar domarku commented on June 18, 2024

Hi @gui-santos,

I like your proposal to change the navigation. I believe it would be a great improvement :)

Thanks ✌️

I'm thinking that the person visiting the docs would have to click the icon and then search. And then if you search something else after that, it's another click + type
What do you think about exposing the search in the bar and having it always there? So the user just needs to type and they get the results

Wouldn't the user have to click into the field to type anyway? I counted the same number of actions. Even in the case of two consecutive queries, the user would:

  1. click in the field (or click on search to toggle a focused search field)
  2. type the query
  3. select and press enter to execute query
  4. click in the field (or click on search to toggle a focused search field)
  5. type the query
  6. ...

I don't mind having the search bar exposed at all times but tbh it's a bit ugly to see on the blue header. Come to think of it, it's the same after we toggle it, too. I'll work on it a bit more.

And I made two quick alternatives for the hover and active states

Thanks for the suggestions, looks good! I prefer the second one:

Screenshot 2020-04-23 at 11 36 57
In this one, we do the same for the hover state, but the active state is the same that you did I've just used the lightest blue.... but Idk

What do you think?

I wouldn't use the lightest blue, though. Perhaps the one between, to keep the contrast to WCAG standards as much as possible.

from forma-36.

domarku avatar domarku commented on June 18, 2024

Looking at it more, @gui-santos, seems like the search is ok where it is now. I'll adjust my issue proposal to only focus on the navigation

from forma-36.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.