Comments (9)
Comment by @aschempp
Saturday Nov 01, 2014 at 09:11 GMT
👍 but we should not hardcode the bundles in AppKernel (see #29)
from core-bundle.
Comment by @leofeyer
Tuesday Nov 04, 2014 at 20:10 GMT
It seems that the version number is wrong, isn't it?
"doctrine/dbal": "~2.2,>=2.2.3"
This is actually the version number used in Symfony for the doctrine/orm
package. The doctrine/dbal
package is somewhere at 2.4 AFAIK. @tristanlins Can you please check?
from core-bundle.
Comment by @tristanlins
Wednesday Nov 05, 2014 at 06:25 GMT
It's right, see https://github.com/symfony/symfony-standard/blob/2.5/composer.json#L12-L13
PS: ORM and DBAL use the same Versioning, the ORM 2.2.3 use DBAL 2.2.*, see https://packagist.org/packages/doctrine/orm#2.2.3
The constraint also allow newer packages like 2.4.x ;-)
from core-bundle.
Comment by @leofeyer
Wednesday Nov 05, 2014 at 08:26 GMT
IMHO you are wrong. If you look at the composer.json
from the version 2.2 branch of Doctrine ORM, you will see that they are using a different constraint to require the DBAL package:
https://github.com/doctrine/doctrine2/blob/2.2/composer.json#L18
from core-bundle.
Comment by @tristanlins
Wednesday Nov 05, 2014 at 09:44 GMT
Huh? This is the composer.json of ORM 2.2, and they require DBAL 2.2.* ??? I don't see a difference here?! O.o
from core-bundle.
Comment by @tristanlins
Wednesday Nov 05, 2014 at 09:46 GMT
Same for ORM 2.3 require DBAL 2.3.* https://github.com/doctrine/doctrine2/blob/2.3/composer.json#L17
and ORM 2.4 require DBAL ~2.4 https://github.com/doctrine/doctrine2/blob/2.4/composer.json#L18
from core-bundle.
Comment by @leofeyer
Wednesday Nov 05, 2014 at 10:02 GMT
All I am saying is that we should require "~2.2"
instead of "~2.2,>=2.2.3"
. The minimum version is only required for the ORM package, not for the DBAL.
from core-bundle.
Comment by @tristanlins
Wednesday Nov 05, 2014 at 10:25 GMT
All I am saying is that we should require
~2.2
instead of~2.2,>=2.2.3
.
Argh okay, sorry for the mistake. Seems you're right.
from core-bundle.
Comment by @tristanlins
Wednesday Nov 05, 2014 at 10:25 GMT
changed https://github.com/tristanlins/contao-contao/commit/d6b8f913cc3785d1c86e72457cb8186886374126
from core-bundle.
Related Issues (20)
- Unvollständige Navigation nach Update auf Contao 4.7.5 HOT 2
- [meta] Porting of imi-conrun feature which are missing in contao-console HOT 4
- Bug in MetaWizard widget HOT 1
- No thumbnails in backend file manager, with php internal webserver HOT 14
- Add option to disable "Lato Retina" HOT 2
- SQLSTATE[HY000]: General error: 1270 Illegal mix of collations (utf8_general_ci,COERCIBLE), (utf8_unicode_ci,COERCIBLE), (utf8_unicode_ci,COERCIBLE) for operation 'replace' HOT 2
- Insert-Tag {{session::*}} HOT 1
- Adding sitemap path and filename to HTML head (fe_page) HOT 1
- Closed FE Preview leaves preview.php in URL HOT 1
- [PHP Fatal Error] Argument passed to FragmentRegistry::get() must be of the type string, object given HOT 3
- [BUG] BackendAccessVoter fails with fatal error when using `allow_if` security access rules - Might not happen in prod enviornment HOT 1
- "Start open/closed" option for accordions HOT 7
- ContentModule: custom cssID not applied when using ModuleProxy HOT 1
- Back link broken due to "referer" issue in session when DCAs have 3+ levels of ptable/ctables HOT 1
- [4.9.X] - Porting the UserCreateCommand class HOT 2
- Fehlende Sprachen HOT 1
- OptInToken.php Mail-Instanz: Absender aus config.yml wird nicht beachtet HOT 3
- Create SECURITY.md HOT 4
- Isotope 2.8.7 breaks when running the Isotope Orders Module in the backend HOT 1
- Backend DCA filter dropdown/select options overwritten - can't have 2 options with the same label HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core-bundle.