Enable the doctrine dbal connection. about core-bundle HOT 9 CLOSED

Comment by @aschempp
Saturday Nov 01, 2014 at 09:11 GMT

👍 but we should not hardcode the bundles in AppKernel (see #29)

from core-bundle.

Comment by @leofeyer
Tuesday Nov 04, 2014 at 20:10 GMT

It seems that the version number is wrong, isn't it?

"doctrine/dbal": "~2.2,>=2.2.3"

This is actually the version number used in Symfony for the doctrine/orm package. The doctrine/dbal package is somewhere at 2.4 AFAIK. @tristanlins Can you please check?

from core-bundle.

Comment by @tristanlins
Wednesday Nov 05, 2014 at 06:25 GMT

It's right, see https://github.com/symfony/symfony-standard/blob/2.5/composer.json#L12-L13

PS: ORM and DBAL use the same Versioning, the ORM 2.2.3 use DBAL 2.2.*, see https://packagist.org/packages/doctrine/orm#2.2.3
The constraint also allow newer packages like 2.4.x ;-)

from core-bundle.

Comment by @leofeyer
Wednesday Nov 05, 2014 at 08:26 GMT

IMHO you are wrong. If you look at the composer.json from the version 2.2 branch of Doctrine ORM, you will see that they are using a different constraint to require the DBAL package:

https://github.com/doctrine/doctrine2/blob/2.2/composer.json#L18

from core-bundle.

Comment by @tristanlins
Wednesday Nov 05, 2014 at 09:44 GMT

Huh? This is the composer.json of ORM 2.2, and they require DBAL 2.2.* ??? I don't see a difference here?! O.o

from core-bundle.

Comment by @tristanlins
Wednesday Nov 05, 2014 at 09:46 GMT

Same for ORM 2.3 require DBAL 2.3.* https://github.com/doctrine/doctrine2/blob/2.3/composer.json#L17
and ORM 2.4 require DBAL ~2.4 https://github.com/doctrine/doctrine2/blob/2.4/composer.json#L18

from core-bundle.

Comment by @leofeyer
Wednesday Nov 05, 2014 at 10:02 GMT

All I am saying is that we should require "~2.2" instead of "~2.2,>=2.2.3". The minimum version is only required for the ORM package, not for the DBAL.

from core-bundle.

Comment by @tristanlins
Wednesday Nov 05, 2014 at 10:25 GMT

All I am saying is that we should require ~2.2 instead of ~2.2,>=2.2.3.

Argh okay, sorry for the mistake. Seems you're right.

from core-bundle.

Comment by @tristanlins
Wednesday Nov 05, 2014 at 10:25 GMT

changed https://github.com/tristanlins/contao-contao/commit/d6b8f913cc3785d1c86e72457cb8186886374126

from core-bundle.