Git Product home page Git Product logo

Comments (2)

aidanhs avatar aidanhs commented on August 28, 2024

FWIW this bump makes musl static builds break for me with

  = note: /nix/store/a1l57qpyyr8rpxxk26lldv42fcjvps6h-x86_64-unknown-linux-musl-binutils-2.35.1/bin/x86_64-unknown-linux-musl-ld: /home/aidanhs/zircon/target/x86_64-unknown-linux-musl/release/deps/libnc-84a6815abfb93d73.rlib(nc-84a6815abfb93d73.nc.2c2307cd896e3a7-cgu.3.rcgu.o): in function `__restore_rt':
          nc.2c2307cd896e3a7-cgu.3:(.text+0x0): multiple definition of `__restore_rt'; /nix/store/hcd122h1i7ablkh2ygc2qjlkjvnzyf3i-rust-1.81.0-nightly-2024-07-19-9057c3ffe/lib/rustlib/x86_64-unknown-linux-musl/lib/self-contained/libc.a(restore.lo):/build/musl-cross-make/build/local/x86_64-linux-musl/obj_musl/../src_musl/src/signal/x86_64/restore.s:6: first defined here

My best guess at a quick look is that the musl __restore_rt is defined like so https://github.com/bminor/musl/blob/dd1e63c3638d5f9afb857fccf6ce1415ca5f1b8b/src/signal/x86_64/restore.s#L5-L7

__restore_rt:
	mov $15, %rax
	syscall

nc used to use the same implementation, so I believe the linker could deduplicate the symbols. But this changed to a custom implementation:

XuShaohua/nc@b67d499#diff-685ac5a9e7e590059d38c8c235bd2b94b36a9e15a7743baa045a7f4383100158L6-L8

from youki.

XuShaohua avatar XuShaohua commented on August 28, 2024

nc v0.9.1 has too many broken changes 😅

from youki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.