Git Product home page Git Product logo

Comments (7)

runcom avatar runcom commented on July 20, 2024

We should probably test if V2 is really supported, otherwise fallback to push v2s1?

from image.

mtrmac avatar mtrmac commented on July 20, 2024

Yes. It would be very convenient if we could determine v2 support without having to create and try to push v2, I am not sure whether that is possible.

from image.

runcom avatar runcom commented on July 20, 2024

@mtrmac it should be easy https://github.com/docker/docker/blob/master/distribution/push_v2.go#L159-L193

from image.

mtrmac avatar mtrmac commented on July 20, 2024

Yeah, that is the “convert and try” method which I’d like to avoid :)

from image.

runcom avatar runcom commented on July 20, 2024

Yeah, that is the “convert and try” method which I’d like to avoid :)

can it work with this "convert and try" though?

from image.

mtrmac avatar mtrmac commented on July 20, 2024

Yeah, that is the “convert and try” method which I’d like to avoid :)

can it work with this "convert and try" though?

Sure, it is software, we can build anything we can specify. But with the increasing number of formats (schema1, schema2, OCI, perhaps even native Docker tar exposed to copy.go), the conversion engine will need to do a series of false starts instead of just statically detecting the optimal destination format and doing a single conversion. Doable but ugly.

from image.

mtrmac avatar mtrmac commented on July 20, 2024

#88 implements the “convert and try” method. At least with the OpenShift acceptschema2 option, there is no way to tell what is supported other than try to push a manifest.

from image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.