Git Product home page Git Product logo

Comments (4)

cyphar avatar cyphar commented on July 20, 2024

Yeah, it looks like distreference.ParseNamed has changed. It's returning this error:

--- FAIL: TestParseReferenceWithTagAndDigest (0.00s)
        reference_test.go:248: Error parsing reference: "busybox:latest@sha256:86e0e091d0da6bde2456dbb48306f3956bbeb2eae1b5b9a43045843f69fe4aaa" is not a valid repository/tag: unsupported digest algorithm

We should note that our current usage of pkg/errors isn't quite right -- we should be using errors.Wrap everywhere.

from image.

runcom avatar runcom commented on July 20, 2024

@cyphar yup (I just woke up though and I'll be traveling today, I'll take a look at this as soon as I can)

Tracking upstream wasn't the best bet thought. Still we need that (also https://github.com/stevvooe/go-digest)

from image.

cyphar avatar cyphar commented on July 20, 2024

@runcom I figured it out, it's because we aren't loading the digest (like the Go library).

from image.

cyphar avatar cyphar commented on July 20, 2024

Fixed in #190.

from image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.