Comments (11)
@kikito Hechos los cambios, travis pasa.
@xuanxu un archivo de texto de 5 lineas no molesta y un cp es mas cómodo, que encontrar el detalle en la documentación y copiar contenido de ahí a un fichero.
Muchas gracias por vuestros comentarios.
from consuldemocracy.
Necesitamos que fijeis tags con versiones para dockerizar. Podéis basarlos en el roadmap o fechas de lanzamiento, pero fijad algún tag inicial... 🔤
from consuldemocracy.
He hecho un PR en #122 al respecto de esto.
Tengo razones técnicas para elegir la imagen base y procedimientos usados, las puedo detallar, debatir y/o cambiar si se requiere.
Espero que os sea útil.
from consuldemocracy.
Gracias @oinak!
En general lo veo OK excepto un par de cosas que cambiaría:
- No modificar el database.yml: El database.yml.example debería hacer que pasen los tests sin tocar nada y con el cambio esto ya no pasa
- No cambiar el mailer de desarrollo: relacionado con la razón anterior quitar letter_opener para usar smtp mete otro requisito de inicio que prefiero evitar.
Ambos cambios asumen que el entorno de desarrollo/tests por defecto va a ser usando Docker, y eso no me convence, a ver qué opina @kikito
from consuldemocracy.
En el caso del database.yml, puedo crear un database.docker-example.yml para ser amigable con el developer que elija docker Y con travis.
En el caso de letter-opener, podemos dejar la gema pero hacer la configuración de action_mailer usar mailcatcher si y solo si hay variables de entorno de Docker, ambos cambios son fáciles.
¿Bastaría con esto?
from consuldemocracy.
Me parecen bien los arreglos, adelante con ellos @oinak
from consuldemocracy.
En cuanto al database.yml yo creo que en vez de añadir un database.docker-example.yml es mejor que simplemente menciones en la documentación los cambios necesarios.
from consuldemocracy.
Hi folks.
Momentum in the UK have got a version of Consul running in Docker. https://github.com/PeoplesMomentum/consul
@binocarlos is the best person to ask about its implementation however.
Apologies for the English!
from consuldemocracy.
Hey @conatus!
We are very happy to see Consul running at Peoples Momentum :))
Yes, we would love to have a Docker way of running Consul.
@binocarlos you think you could send us a PR with the basics?
Cheers and all the best at https://mxv.peoplesmomentum.com/
from consuldemocracy.
Seems Barcelona's fork also has support for Docker but in a less comprehensive way than Momentum.
https://github.com/AjuntamentdeBarcelona/decidim.barcelona
from consuldemocracy.
Closed via #2127
from consuldemocracy.
Related Issues (20)
- Geozone Geojson map rendering
- Active storage not loading images HOT 1
- Stopping puma with Systemd takes too long
- Admin Statistics not updating due to cache HOT 1
- Investment admin opens in new window HOT 3
- Facilitating Discovery for Dutch Municipalities through publiccode.yml Addition HOT 1
- Replace CKEditor 4 with a maintained editor HOT 2
- Use buttons instead of links in the public area
- Legacy code in puma config HOT 2
- Linters workflow for GitHub Actions fails for forks
- Replace Errbit/Airbrake with Sentry
- Replace Turbolinks with Turbo or drop it entirely
- Social login buttons alignment HOT 4
- sassc-embedded-import: Can't find stylesheet to import HOT 2
- Budget Investments displaying as Winning Investments when Display Results is unchecked
- Show supports on investments only if selecting phase is enabled
- Display polls results in rows
- bug comments are not linked to the original text after edit HOT 1
- Poll and budget demographic stats change over time
- Failure to install due to faker gem not being properly invoked in users.rb HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from consuldemocracy.