RPCClient doesn't work with long username / password about consensusj HOT 5 CLOSED

This Base64 implementation (file) was copied from the Android project -- didn't want an external dependency, but wanted a solid implementation. Do you know if the issue had been reported or fixed upstream?

from consensusj.

A lot of base64 implementations insert newlines for "pretty-printing". It's not an issue w/ the Base64 implementation IMO. Also, it looks like Base64 is an internal library? com.msgilligan.jsonrpc.util.Base64. There is also java.util.Base64 which obviously doesn't have any external dependencies, but I'm not sure what its status with newlines is. Worst case, it should be easy to use String.replace("\n", ""), or something similar.

from consensusj.

It's internal, but copied (with copyright notice intact) from Android.

We needed to:

1. Have something that works on Java and Android
2. Avoid namespace conflicts
3. Avoid any external dependencies

from consensusj.

java.util.Base64 is added in Android API level 26 (aka Android 8.0, "Oreo")

So, unless you're developing for Android 8.0 or later and you want the same code to work on Java and Android you have to provide your own implementation (or a factory, etc)

from consensusj.

Fixed by c935710 -- on master branch -- will be in next release.

from consensusj.