Git Product home page Git Product logo

Comments (8)

A1ic3-g avatar A1ic3-g commented on August 22, 2024 1

@connertennery I can confirm the fix works for my notion export :)

from notion-to-obsidian-converter.

carloslab-ai avatar carloslab-ai commented on August 22, 2024 1

Hi, I've had another problem about this:

Link Before Convert:
![Draw call batching.png]
(Optimize%20Draw%20Calls%20385de85d71e1473db332c309eb5ed696/Draw_call_batching.png)

Link After Convert:
![[/Draw call batching.png]]

But the name of the image is "Draw_call_batching.png", so it doesn't work as expected.

from notion-to-obsidian-converter.

A1ic3-g avatar A1ic3-g commented on August 22, 2024

I'm also having this issue

from notion-to-obsidian-converter.

connertennery avatar connertennery commented on August 22, 2024

Hi @MilkClouds and @A1ic3-g! Thanks for submitting the issue and providing a good example. I can't guess at the problem right away, but I think it might be an issue with the script not selecting the right path due to the subdirectory that contains the Untitled.png image. I'll try to patch this soon.

from notion-to-obsidian-converter.

connertennery avatar connertennery commented on August 22, 2024

Hey @MilkClouds and @A1ic3-g, I just got a chance to look at this tonight and I believe I can see what the problem is, but to make sure I'm understanding the right scenario so I can fix it, would either of you be willing to submit an example export with this issue? I'm unable to create any exports from Notion that create the same link structure.

from notion-to-obsidian-converter.

MilkClouds avatar MilkClouds commented on August 22, 2024

Export-c453802b-7558-4120-b748-a4f3524f170f.zip

Export settings are below:
image

from notion-to-obsidian-converter.

connertennery avatar connertennery commented on August 22, 2024

@MilkClouds Thank you for the example export and for the pull request. :) I think I have a fix that should work well without disabling regex. I tested it a few times and tried to tweak the links in your export but it all seems to work well.

from notion-to-obsidian-converter.

janghwan avatar janghwan commented on August 22, 2024

I'm having the same issue as @carlos-truong mentioned. please re-open this issue. I actually made a fix.

from notion-to-obsidian-converter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.