Comments (4)
I think you're saying that, when the app first starts up, it does not correctly figure out whether the current time is between the StartDay and EndDay, correct?
from quickfixn.
correct, the issue is in CheckTime not accounting for the usage of StartDay & EndDay
from quickfixn.
Confirmed.
This is pretty easy to reproduce.
For example, given these settings:
StartTime=00:30:00
EndTime=01:00:00
StartDay=Monday
EndDay=Saturday
The above settings define a session as starting Monday 00:30:00 and ending Saturday at 01:00:00.
So, if it's Tuesday at 10:00:00, that is within the session, and an initiator should try to connect.
BUT -- it appears that QF/J is judging this wrong. It is ignoring the day. It is checking whether 10:00:00 is within 00:30:00-01:00:00 (e.g. a half-hour session).
TO REPRODUCE:
Configure TradeClient config file with a weeklong session similar to the above, where the EndTime is just a little after the StartTime, but the days are far apart. Then run TradeClient.exe. You'll see that TradeClient does not try to connect.
from quickfixn.
Looks like your fix broke test SessionScheduleTests.testWeeklySessionMultiDayHours(). Can you investigate and resubmit?
from quickfixn.
Related Issues (20)
- Unhelpful behaviour for unknown fields HOT 1
- deployment script redesign
- Yes, we know the mailing list is down HOT 1
- Release 1.11.0 announcement
- DDField.cs SEQNUM type is still int after 24x7 ulong implementation HOT 1
- not able to capture the return message after login and seq mismatch HOT 2
- "Acceptor heartbeat set to" log message is wrong
- In Logout session, the field=553(Username) is redundant HOT 2
- Udp protocol support HOT 1
- FIX50 IOIQty does not allow Numeric Quantity HOT 2
- Not send Missing Application messages to the receiving application as response for Resend Request HOT 2
- Unhandled Exception in SocketInitiator.OnStart() can Terminate Process HOT 8
- Enhanced CME Globex Resend Logic HOT 3
- Wrong time format for TimeStampPrecision=NANO HOT 4
- Weekdays setting implementation HOT 1
- setting "TimeStampPrecision" is not documented
- performance tests HOT 2
- When Acceptor initiates Logoff, it doesn't wait for the Logoff response HOT 1
- Possible release of 1.10.1 for .net standard users with deadlock fix released as part of 1.11.0 HOT 1
- GroupDelimiterTagException : Group X 's first entry does not start with delimiter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickfixn.