Git Product home page Git Product logo

Comments (4)

gbirchmeier avatar gbirchmeier commented on July 21, 2024

I think you're saying that, when the app first starts up, it does not correctly figure out whether the current time is between the StartDay and EndDay, correct?

from quickfixn.

glavian avatar glavian commented on July 21, 2024

correct, the issue is in CheckTime not accounting for the usage of StartDay & EndDay

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

Confirmed.

This is pretty easy to reproduce.

For example, given these settings:
StartTime=00:30:00
EndTime=01:00:00
StartDay=Monday
EndDay=Saturday

The above settings define a session as starting Monday 00:30:00 and ending Saturday at 01:00:00.

So, if it's Tuesday at 10:00:00, that is within the session, and an initiator should try to connect.

BUT -- it appears that QF/J is judging this wrong. It is ignoring the day. It is checking whether 10:00:00 is within 00:30:00-01:00:00 (e.g. a half-hour session).

TO REPRODUCE:
Configure TradeClient config file with a weeklong session similar to the above, where the EndTime is just a little after the StartTime, but the days are far apart. Then run TradeClient.exe. You'll see that TradeClient does not try to connect.

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

Looks like your fix broke test SessionScheduleTests.testWeeklySessionMultiDayHours(). Can you investigate and resubmit?

from quickfixn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.