Comments (10)
We have a DateOnly field, but DDField is still wrong.
from quickfixn.
DateOnly and TimeOnly are in DateTimeField.cs
from quickfixn.
Do we have example of failure? (Something I can build a test around?)
from quickfixn.
No Fixtest that covers this yet.
Just need to make a test expecting that fields that are UTCDateOnly and
UTCTimeOnly. I'll work on that test, and let you know when its done.
On Wed, Nov 30, 2011 at 9:37 AM, gbirchmeier <
[email protected]
wrote:
Do we have example of failure? (Something I can build a test around?)
Reply to this email directly or view it on GitHub:
#5 (comment)
Kirk
from quickfixn.
Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.
There's 2 parts to this:
- The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
- The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.
Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.
from quickfixn.
The validate function! Been so long.
We're you able to get this in? I can hop on it of not.
Kirk
On Nov 30, 2011, at 5:16 PM, [email protected] wrote:
Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.
There's 2 parts to this:
- The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
- The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.
Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.
Reply to this email directly or view it on GitHub:
#5 (comment)
from quickfixn.
I was not. I might take it up on the plane ride back, though. Or
Monday morning. If you want to hit it, I don't mind. Let me know if
you do though.
from quickfixn.
Will do. I'll see what I get to today.
Kirk
On Dec 2, 2011, at 7:36 AM, [email protected] wrote:
I was not. I might take it up on the plane ride back, though. Or
Monday morning. If you want to hit it, I don't mind. Let me know if
you do though.On Wed, Nov 30, 2011 at 6:40 PM, kkozel
[email protected]
wrote:The validate function! Been so long.
We're you able to get this in? I can hop on it of not.Kirk
On Nov 30, 2011, at 5:16 PM, [email protected] wrote:
Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.
There's 2 parts to this:
- The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
- The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.
Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.
Reply to this email directly or view it on GitHub:
#5 (comment)
Reply to this email directly or view it on GitHub:
#5 (comment)
Reply to this email directly or view it on GitHub:
#5 (comment)
from quickfixn.
I started working on this yesterday.
from quickfixn.
Turns out we're not validating the types of any fields within repeating groups.
I found this because DateOnly/TimeOnly only occurs in repeating groups in our DDs. My tests weren't working because of this.
So I'll be fixing that too.
from quickfixn.
Related Issues (20)
- Release 1.11.0 announcement
- DDField.cs SEQNUM type is still int after 24x7 ulong implementation HOT 1
- not able to capture the return message after login and seq mismatch HOT 2
- "Acceptor heartbeat set to" log message is wrong
- In Logout session, the field=553(Username) is redundant HOT 2
- Udp protocol support HOT 1
- FIX50 IOIQty does not allow Numeric Quantity HOT 2
- Not send Missing Application messages to the receiving application as response for Resend Request HOT 2
- Unhandled Exception in SocketInitiator.OnStart() can Terminate Process HOT 8
- Enhanced CME Globex Resend Logic HOT 3
- Wrong time format for TimeStampPrecision=NANO HOT 4
- Weekdays setting implementation HOT 1
- setting "TimeStampPrecision" is not documented
- performance tests HOT 2
- When Acceptor initiates Logoff, it doesn't wait for the Logoff response HOT 1
- Possible release of 1.10.1 for .net standard users with deadlock fix released as part of 1.11.0 HOT 1
- GroupDelimiterTagException : Group X 's first entry does not start with delimiter HOT 2
- Consider adding a package icon HOT 4
- Problem when debugging HOT 3
- Timing issue loading DLLs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickfixn.