Git Product home page Git Product logo

Comments (10)

kennystone avatar kennystone commented on July 21, 2024

We have a DateOnly field, but DDField is still wrong.

from quickfixn.

kkozel avatar kkozel commented on July 21, 2024

DateOnly and TimeOnly are in DateTimeField.cs

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

Do we have example of failure? (Something I can build a test around?)

from quickfixn.

kkozel avatar kkozel commented on July 21, 2024

No Fixtest that covers this yet.
Just need to make a test expecting that fields that are UTCDateOnly and
UTCTimeOnly. I'll work on that test, and let you know when its done.

On Wed, Nov 30, 2011 at 9:37 AM, gbirchmeier <
[email protected]

wrote:

Do we have example of failure? (Something I can build a test around?)


Reply to this email directly or view it on GitHub:
#5 (comment)

Kirk

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.

There's 2 parts to this:

  1. The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
  2. The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.

Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.

from quickfixn.

kkozel avatar kkozel commented on July 21, 2024

The validate function! Been so long.
We're you able to get this in? I can hop on it of not.

Kirk

On Nov 30, 2011, at 5:16 PM, [email protected] wrote:

Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.

There's 2 parts to this:

  1. The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
  2. The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.

Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.


Reply to this email directly or view it on GitHub:
#5 (comment)

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

I was not. I might take it up on the plane ride back, though. Or
Monday morning. If you want to hit it, I don't mind. Let me know if
you do though.

from quickfixn.

kkozel avatar kkozel commented on July 21, 2024

Will do. I'll see what I get to today.

Kirk

On Dec 2, 2011, at 7:36 AM, [email protected] wrote:

I was not. I might take it up on the plane ride back, though. Or
Monday morning. If you want to hit it, I don't mind. Let me know if
you do though.

On Wed, Nov 30, 2011 at 6:40 PM, kkozel
[email protected]
wrote:

The validate function! Been so long.
We're you able to get this in? I can hop on it of not.

Kirk

On Nov 30, 2011, at 5:16 PM, [email protected] wrote:

Ok, this bug isn't about Message decoding from string (which this doesn't appear to affect), it's about the basic class interface.

There's 2 parts to this:

  1. The Ruby code generator generates time-only and date-only fields as DateTimeFields. We should fix this.
  2. The DD created in the engine is not using the correct DateTime-derived types when validating messages. That's what the DDField.cs function will affect.

Note to Kirk: After creating a message from a string, you have to call dd.Validate(). That's where the DD comes into play and wrong-type exceptions get thrown. Should have realized it sooner.


Reply to this email directly or view it on GitHub:
#5 (comment)


Reply to this email directly or view it on GitHub:
#5 (comment)


Reply to this email directly or view it on GitHub:
#5 (comment)

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

I started working on this yesterday.

from quickfixn.

gbirchmeier avatar gbirchmeier commented on July 21, 2024

Turns out we're not validating the types of any fields within repeating groups.

I found this because DateOnly/TimeOnly only occurs in repeating groups in our DDs. My tests weren't working because of this.

So I'll be fixing that too.

from quickfixn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.