Comments (6)
Discussion:
QF/C++ and QF/J both write groups elements in the DD order, per FIX.4.4 spec.
Right now we're obeying FIX.5 spec, and putting the delimiter field first, and tag order afterward. Ostensibly, this might be for a slight perf gain, but this is entirely unmeasured.
I don't think breaking from established QF behavior is justified.
from quickfixn.
I put in a fix so that it now defaults to FIX.4.4 behavior, which is to write group element in DD order. This also satisfies the looser FIX.5 expectations.
If anyone wants to implement an option to write group elements in a non-DD or unspecified order (but the delimiter must come first) under the auspice that it might be faster, they are welcome to do so, but I think measurements should definitely be presented to confirm that such a feature is useful.
from quickfixn.
i have downloaded to latest code on github and tried this issue. But it seems not to be solved completely.
Below codes makes fix message with '8=FIX.4.4|9=161|35=BB|34=7|49=REMOTECOMPID|50=USERA|52=20120202-15:48:57.543|56=TARGETCOMPID|263=0|909=CollateralInquiry|453=1|448=ABC|447=D|452=4|802=1|802=1|523=ABC|803=1|10=196|'
Tag NoPartySubIDs(802) appears more than once. And it causes to reject this message. i think there is problem on calculating string for inner groups. this issue should be reopened.
QuickFix.FIX44.CollateralInquiry ci = new QuickFix.FIX44.CollateralInquiry();
ci.CollInquiryID = new QuickFix.Fields.CollInquiryID("CollateralInquiry");
ci.SubscriptionRequestType = new QuickFix.Fields.SubscriptionRequestType(QuickFix.Fields.SubscriptionRequestType.SNAPSHOT);
CollateralInquiry.NoPartyIDsGroup noParty = new CollateralInquiry.NoPartyIDsGroup();
noParty.PartyID = new QuickFix.Fields.PartyID("ABC");
noParty.PartyIDSource = new QuickFix.Fields.PartyIDSource(QuickFix.Fields.PartyIDSource.PROPRIETARY_CUSTOM_CODE);
noParty.PartyRole = new QuickFix.Fields.PartyRole(QuickFix.Fields.PartyRole.CLEARING_FIRM);
CollateralInquiry.NoPartyIDsGroup.NoPartySubIDsGroup noPartySub = new CollateralInquiry.NoPartyIDsGroup.NoPartySubIDsGroup();
noPartySub.PartySubID = new QuickFix.Fields.PartySubID("ABC");
noPartySub.PartySubIDType = new QuickFix.Fields.PartySubIDType(QuickFix.Fields.PartySubIDType.FIRM);
noParty.AddGroup(noPartySub);
ci.AddGroup(noParty);
QuickFix.Session.SendToTarget(message);
from quickfixn.
Dang. Thanks for reporting, and thanks for your excellent write-up. I will look into this soon.
from quickfixn.
I think I've fixed this one (again). Closing it. Please checkout the latest and let me know if you notice any more problems.
from quickfixn.
karabiberoglu, if you see a more issues, please submit a new bug rather than reopen this one. Thanks.
from quickfixn.
Related Issues (20)
- Release 1.11.0 announcement
- DDField.cs SEQNUM type is still int after 24x7 ulong implementation HOT 1
- not able to capture the return message after login and seq mismatch HOT 2
- "Acceptor heartbeat set to" log message is wrong
- In Logout session, the field=553(Username) is redundant HOT 2
- Udp protocol support HOT 1
- FIX50 IOIQty does not allow Numeric Quantity HOT 2
- Not send Missing Application messages to the receiving application as response for Resend Request HOT 2
- Unhandled Exception in SocketInitiator.OnStart() can Terminate Process HOT 8
- Enhanced CME Globex Resend Logic HOT 3
- Wrong time format for TimeStampPrecision=NANO HOT 4
- Weekdays setting implementation HOT 1
- setting "TimeStampPrecision" is not documented
- performance tests HOT 2
- When Acceptor initiates Logoff, it doesn't wait for the Logoff response HOT 1
- Possible release of 1.10.1 for .net standard users with deadlock fix released as part of 1.11.0 HOT 1
- GroupDelimiterTagException : Group X 's first entry does not start with delimiter HOT 2
- Consider adding a package icon HOT 4
- Problem when debugging HOT 3
- Timing issue loading DLLs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickfixn.