Comments (7)
@gardusig Looks like you can reference environment variables in setup.cfg: https://stackoverflow.com/a/30679041
Also to validate a release after its published to pypi from Github Actions -- you might want to have a small sleep if there is a delay before it become available in pypi, but I would have a build step after the publish to pypi where you can either create a new virtualenv, or ensure that the package is no longer installed in your system environment -- then pip install from pypi the package and invoke python -c "import conductor"
would do a sanity check that the module can be imported. The problem though is if you have already published to pypi and this check fails, now you have to yank it. Would be better to just build the package ahead of time and import that and see that it works before publishing now that I think more about it.
from conductor-python.
1.0.31
was removed from pypi by now, working on a fix and will publish it as 1.0.32
soon.
Looks like some misconfig from setup.cfg
migration to setup.py
from conductor-python.
Hey @aaj, I've just released 1.0.32
at pypi: https://pypi.org/project/conductor-python/1.0.32/
I think your issue should be solved by now :)
Special thanks for the quick feedback!
from conductor-python.
@gardusig awesome! Super quick turnaround, thanks for the heads up 🤗
from conductor-python.
Taking a look at it
from conductor-python.
Just curious @gardusig why to move from setup.cfg towards setup.py? When the setup.cfg is newer and seems to be the preferred direction that setuptools is heading in. I help maintain pipenv and any insights you could share would be useful to me. Thanks!
from conductor-python.
Hey @matteius, I think this move was probably due to a bad solution aiming to fix an issue that I've faced: while creating a CI/CD pipeline, I wanted to change the setup to accept ENV vars previously set here on GitHub.
I'm not sure if it's possible to do that with only setup.cfg
, the fastest way I found to solve this was to use a setup.py
, which can read from os.environ
and solves the problem without much effort :)
In the meantime to current latest release, I've just moved everything from .cfg
to .py
and forgot to add the actual package_dir
parameter in the setup.
BTW appreciate any ideas on how to validate a release after it's published at pypi from GitHub Actions.
from conductor-python.
Related Issues (20)
- Complete SecretClient in Python SDK
- Complete MetadataClient in Python SDK
- Fix TaskHandler error in get_annotated_workers
- 'NoneType' object is not iterable when trying to iterate on the workflow.results
- Refactor tests in Python SDk
- Register workflow with override=true still generates a 409 error
- Task Input Data with params of 0 are getting converted to None
- KafkaPublishInput missing swagger attributes
- Falsy values in the json response converted to None HOT 1
- Add support for the JUMP operator
- Add WorkflowCreator to Python SDK
- Conductor Python workers do not acknowledge SIGTERM
- [Bug] Worker with generic input and output is not supported HOT 1
- Conductor API for updateWorkflowDef doesn't support updating onStateChange values HOT 1
- ImportError: cannot import name 'Self' from 'typing' in Conductor Python library HOT 2
- Workers graceful shutdown being sure that current executions are not truncated HOT 3
- TypeError: 'type' object is not subscriptable HOT 1
- Get AuthorizationException when trying to update variables of a started workflow HOT 1
- Hjffjkfgjdk
- PicklingError When Running helloworld Script
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conductor-python.