Git Product home page Git Product logo

Comments (5)

Jaskowicz1 avatar Jaskowicz1 commented on June 14, 2024

Just to add, if you get an abort with an invalid token (if you manage to figure it out or whatnot) when running the .exe, that's normal. Put a try catch around the bot.start() if you would rather not get an abort.

from conan.

Jaskowicz1 avatar Jaskowicz1 commented on June 14, 2024

Another note to add, Conan does generate release versions of all the requirements too.
image
So it's even more confusing why Debug works here.

If you flip Release for Debug and Debug for Release as you follow the steps, you'll get the same outcome (but ofc flipped so binaries will be in Release).

from conan.

memsharded avatar memsharded commented on June 14, 2024

Hi @Jaskowicz1

Thanks for your report, I am having a look.

I also have some feedback about the branch and the conanfile.py inside the library-conan, where should I report it?

Quick feedback about:

Re-run cmake .. -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE="conan_toolchain.cmake" -DCMAKE_BUILD_TYPE=Release

VS is a multi-config generator, and as such CMAKE_BUILD_TYPE shouldn't be neither defined nor used. This might be related to the issue, I am building the project, but if you can try to drop it and try again to see if it helps, that would be great too.

from conan.

Jaskowicz1 avatar Jaskowicz1 commented on June 14, 2024

Thank you for taking a look, @memsharded !

I also have some feedback about the branch and the conanfile.py inside the library-conan, where should I report it?

https://github.com/brainboxdotcc/DPP/pull/1066 would be the best place! That way the feedback is directly on the PR!

VS is a multi-config generator, and as such CMAKE_BUILD_TYPE shouldn't be neither defined nor used. This might be related to the issue, I am building the project, but if you can try to drop it and try again to see if it helps, that would be great too.

I'll certainly give another run without to see what happens!

from conan.

memsharded avatar memsharded commented on June 14, 2024

Some issues that I am seeing:

  • The package is storing headers in the dpp-10.0 folder:
 Installing: C:/Users/..../.conan2/p/b/dpp2166487df2998/p/include/dpp-10.0/dpp/timer.h
-- Installing: C:/Users/.../.conan2/p/b/dpp2166487df2998/p/include/dpp-10.0/dpp/unicode_emoji.h

But the recipe is using the default package_info() which defaults to include folder.
The recipe should do something like:

def package_info(self):
     self.cpp_info.includedirs = ["include/dpp-10.0"]

Likewise:

-- Installing: C:/Users/.../.conan2/p/b/dpp2166487df2998/p/lib/dpp-10.0/dpp.lib

So something like:

def package_info(self):
     self.cpp_info.includedirs = ["include/dpp-10.0"]
     self.cpp_info.libdirs= ["lib/dpp-10.0"]

I'd suggest to have a look to https://docs.conan.io/2/tutorial/creating_packages/define_package_information.html

Also, Conan has a built-in functionality, the test_package that automatically runs this check without having to have another separate project to test that it has been correctly packaged. Please check https://docs.conan.io/2/tutorial/creating_packages/test_conan_packages.html. You can start from the conan new cmake_lib -d name=mypkg -d version=0.1 to have a fully working package and test_package.

from conan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.